Update prompt syntax #283
Open
Update prompt syntax #283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for luxury-shortbread-acee05 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
@faiqibrahim the quotation changes look different than what you had said. Can you please verify?
| @@ -90,9 +90,11 @@ functions. Finally, it generates a [summary](docs/learn/grounded-generation/sele | |||
| [ | |||
| {"role": "system", "content": "You are a helpful search assistant."}, | |||
| #foreach ($qResult in $vectaraQueryResults) | |||
| {"role": "user", "content": "Give me the $vectaraIdxWord[$foreach.index] search result."}, | |||
There was a problem hiding this comment.
If you can, let's not break these sentences (same for other changes in this PR)? Moving part of the JSON line to the next line makes it less readable (I'm assuming this will get displayed as it is here). The preview doesn't show it on next line, so okay then :)
|
@faiqibrahim please review and approve. |
Signed-off-by: Paul Wozniczka <25128922+pwoznic@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated syntax based on Slack discussion