Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore Unix Hidden Files for Analogy Task #78

Closed
wants to merge 2 commits into from

Conversation

yuanzhiKe
Copy link

The unix-like systems like mac and linux distributions will automatically create some hidden files whose names are started with '.' under the data folders, which makes the analogy.py down
I simply add 2 lines to let it ignore such files.

The unix-like systems like mac and linux distributions will automatically create some hidden files whose names are started with '.' under the data folders, which makes the analogy.py down
I simply add 2 lines to let it ignore such files.
@coveralls
Copy link

Pull Request Test Coverage Report for Build 846

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.001%) to 95.114%

Totals Coverage Status
Change from base Build 843: 0.001%
Covered Lines: 4516
Relevant Lines: 4748

💛 - Coveralls

@undertherain
Copy link
Contributor

Thank you for noticing this and trying to contribute to code right away

Few points about your PR:

  1. other benchmarks also use datasets with multiple files. This path should go not to the analogy module, but to Dataset class

  2. please do not violate coding standards in order to reduce number of lines not covered with tests. instead add a file starting with . to the test dataset

  3. using split on paths is not the best practice. widows users use forward slash instead of back slash. use methods of os module.

@yuanzhiKe
Copy link
Author

Thank you for noticing this and trying to contribute to code right away

Few points about your PR:

  1. other benchmarks also use datasets with multiple files. This path should go not to the analogy module, but to Dataset class
  2. please do not violate coding standards in order to reduce number of lines not covered with tests. instead add a file starting with . to the test dataset
  3. using split on paths is not the best practice. widows users use forward slash instead of back slash. use methods of os module.

Thank you for your quick reply.
Sorry for the mistakes.
I will update test scripts as well, and use os.path to get the filename.

@yuanzhiKe yuanzhiKe closed this May 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants