Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Context#withStyledAttributes extension function. #1546

Merged
merged 1 commit into from
Jul 10, 2020
Merged

Use Context#withStyledAttributes extension function. #1546

merged 1 commit into from
Jul 10, 2020

Conversation

johnjohndoe
Copy link
Contributor

@johnjohndoe johnjohndoe force-pushed the styledattributeset branch 4 times, most recently from dff5ae8 to 82b7fef Compare June 26, 2020 16:09
@johnjohndoe
Copy link
Contributor Author

Flaky Android tests .. 🦜

@bmarty
Copy link
Member

bmarty commented Jun 26, 2020

Flaky Android tests .. 🦜

Yes, we will fix that, thanks :)

@johnjohndoe
Copy link
Contributor Author

Magically self-healing :)

bmarty
bmarty approved these changes Jun 29, 2020
View reviewed changes
Copy link
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the PR. We will merge it in a few days.

@johnjohndoe
Copy link
Contributor Author

Thanks. Feel free to rebase the branch before merging it to facilitate a linear history. Let me know if I should do this.

@johnjohndoe johnjohndoe force-pushed the styledattributeset branch 2 times, most recently from ab68051 to 9909ab1 Compare July 2, 2020 16:07
@johnjohndoe
Copy link
Contributor Author

Rebased. Moved the CHANGES entry to the new version block.

@bmarty bmarty merged commit 825e213 into element-hq:develop Jul 10, 2020
@johnjohndoe johnjohndoe deleted the styledattributeset branch July 10, 2020 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmarty bmarty bmarty approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@johnjohndoe @bmarty