Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Context#getSystemService extension function provided by core-ktx. #1702

Merged
merged 1 commit into from
Aug 11, 2020

Conversation

johnjohndoe
Copy link
Contributor

@johnjohndoe johnjohndoe commented Jul 16, 2020

Signed-off-by: Tobias Preuss tobias.preuss@googlemail.com


Feel free to rebase the branch before merging it to facilitate a linear history. Let me know if I should do this.

@johnjohndoe johnjohndoe force-pushed the system-service branch 3 times, most recently from 460a0de to b1fae9b Compare July 21, 2020 22:27
@johnjohndoe
Copy link
Contributor Author

Rebased and rebase conflicts resolved.

@johnjohndoe
Copy link
Contributor Author

Rebased once more.

…tx".

+ Re-use local variable where possible.
@johnjohndoe
Copy link
Contributor Author

Rebased and rebase conflicts resolved.

Copy link
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the rebase!

@bmarty bmarty merged commit b18a874 into element-hq:develop Aug 11, 2020
@bmarty
Copy link
Member

bmarty commented Aug 11, 2020

FTR I have added a c ommit (on develop) to ensure that we will always use this facility: 7b017e4

@johnjohndoe
Copy link
Contributor Author

Ah! Nice. That is a good idea. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants