Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement MSC3987: Push actions clean-up #8530

Merged
merged 2 commits into from
Jun 16, 2023
Merged

Implement MSC3987: Push actions clean-up #8530

merged 2 commits into from
Jun 16, 2023

Conversation

yostyle
Copy link
Contributor

@yostyle yostyle commented Jun 13, 2023 •
edited

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

#8503

Motivation and context

Screenshots / GIFs

Tests

  • Step 1
  • Step 2
  • Step ...

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

@yostyle yostyle requested review from a team, Florian14 and ganfra and removed request for a team and Florian14 June 13, 2023 10:21
@yostyle yostyle requested a review from giomfo June 13, 2023 10:55
@sonarcloud
Copy link

sonarcloud bot commented Jun 13, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@yostyle yostyle marked this pull request as ready for review June 13, 2023 12:40
@yostyle yostyle requested review from a team and jonnyandrew and removed request for ganfra and a team June 15, 2023 08:12
jonnyandrew
jonnyandrew approved these changes Jun 15, 2023
View reviewed changes
Copy link
Contributor

@jonnyandrew jonnyandrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

giomfo
giomfo approved these changes Jun 15, 2023
View reviewed changes
Copy link
Member

@giomfo giomfo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM

@yostyle yostyle merged commit 710d21f into develop Jun 16, 2023
23 checks passed
@yostyle yostyle deleted the yostyle/cleanup_pushrule branch June 16, 2023 09:13
@S7evinK S7evinK mentioned this pull request Oct 23, 2023
Merged
S7evinK added a commit to matrix-org/dendrite that referenced this pull request Oct 24, 2023
@S7evinK
Implement MSC3987, fix setting Element Android notifications (#3242)
1b124fe 
Should fix #3183, since
Element Android already implements
[MSC3987](element-hq/element-android#8530)

This is also part of #3225
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonnyandrew jonnyandrew jonnyandrew approved these changes

@giomfo giomfo giomfo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@yostyle @jonnyandrew @giomfo