Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure Background sync is not stopped when there is an active call. #8674

Merged
merged 2 commits into from Nov 23, 2023

Conversation

bmarty
Copy link
Member

@bmarty bmarty commented Nov 7, 2023

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

Ensure Background sync is not stopped when there is an active call.
It was happening since the application is foregrounded when VectorCallActivity is displayed.

Motivation and context

Closes #4066

Screenshots / GIFs

Tests

  1. Clear task (make sure Element is not running on the background).
  2. Turn off/lock the screen.
  3. Don't do anything, let the screen wake up by itself from call notification.
  4. Don't pick up the call.

Then either the caller cancel the call, or answer the call from another session.

Previously the call was ringing forever. With this change, the device stops ringing, and the background sync is correctly cancelled. The device does not need to sync forever once the call is over.

Also did some smoke test around call, since this code is quite complex and not covered by unit tests.

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

@bmarty bmarty requested review from a team and jonnyandrew and removed request for a team November 7, 2023 15:40
It was happening since the application is foregrounded when VectorCallActivity is displayed.
@bmarty bmarty force-pushed the feature/bma/infiniteRingCall branch from 57d5d62 to 8d85d04 Compare November 22, 2023 08:44
Copy link

sonarcloud bot commented Nov 22, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

warning The version of Java (11.0.21) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@bmarty bmarty merged commit 0c1f190 into develop Nov 23, 2023
13 of 14 checks passed
@bmarty bmarty deleted the feature/bma/infiniteRingCall branch November 23, 2023 16:45
@opusforlife2
Copy link
Contributor

Hi, @bmarty. There's no release issue for 1.6.8, so I'm pinging you here. Could you please let the F-Droid team know so that F-Droid users can get this version?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incoming voice call rings forever
3 participants