Only set enable-features if the user hasn't
#261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ma27
added a commit
to Ma27/nixpkgs
that referenced
this pull request
Sep 13, 2021
See upstream PR#261[1] for further reference. Previously, the `enable-features`-setting was entirely discarded due to an earlier regression resulting in an attempt to start `element-desktop` in Wayland-mode without all necessary components. Closes NixOS#137377 [1] element-hq/element-desktop#261
12 tasks
yu-re-ka
pushed a commit
to NixOS/nixpkgs
that referenced
this pull request
Sep 13, 2021
See upstream PR#261[1] for further reference. Previously, the `enable-features`-setting was entirely discarded due to an earlier regression resulting in an attempt to start `element-desktop` in Wayland-mode without all necessary components. Closes #137377 [1] element-hq/element-desktop#261
|
Can we get this into the next 1.8.x release? The new feature that broke it was added in a bugfix release (1.8.2) after all. |
|
It will be in the next scheduled release, yes. |
Ma27
added a commit
to Ma27/nixpkgs
that referenced
this pull request
Sep 13, 2021
See upstream PR#261[1] for further reference. Previously, the `enable-features`-setting was entirely discarded due to an earlier regression resulting in an attempt to start `element-desktop` in Wayland-mode without all necessary components. Closes NixOS#137377 [1] element-hq/element-desktop#261 (cherry picked from commit 5a0d0ec)
12 tasks
yu-re-ka
pushed a commit
to NixOS/nixpkgs
that referenced
this pull request
Sep 14, 2021
See upstream PR#261[1] for further reference. Previously, the `enable-features`-setting was entirely discarded due to an earlier regression resulting in an attempt to start `element-desktop` in Wayland-mode without all necessary components. Closes #137377 [1] element-hq/element-desktop#261 (cherry picked from commit 5a0d0ec)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the issue mentioned in my comment in #256
Here's what your changelog entry will look like:
馃悰 Bug Fixes
enable-featuresif the user hasn't (#261). Contributed by yu-re-ka.