Jump to first unread message doesn't show up in 0.7.12 TF

[aaronraimist]

On my phone the "Jump to first unread message" bar never shows up. If I manually scroll back far enough the green line does show up so Riot does now how far back I was, it just doesn't prompt be to jump back there.

[fridtjof]

After pinning down by binary searching through the commit history manually, this commit broke the unread banner (partially):
fc86a37

Interestingly, the banner appears when you tap on the navigation bar to expand it, and stays when you swipe up on the nav bar to un-expand it.

Removing line 422 fixes the banner, but breaks the navbar when expanding it. This can be fixed by re-adding lines 1489 and 1490 (fc86a37#diff-fb832478437f1f5120fc0de91a34a081L1489). Essentially, the entire commit could be reverted.

I will make a PR to fix this, but @manuroe should review it - I don't know enough about this part of the project, and the iOS view system yet 😅

[manuroe]

The banner is still here (see below) but it is displayed under the navigation bar. The system decided to put it upper because of the navigation bar in now translucent.

[fridtjof]

Whoa. Out of curiousity, where do I find that debug view? I wish I would've had that a week ago 😂

On topic, this makes a lot of sense to me now, after really scratching my head as to why it would just disappear like that. What do you think is the best solution for this? I'm really rusty with the iOS view system, but is it possible to tell iOS to treat the nav bar the same way no matter if it's translucent or not?

[manuroe]

Whoa. Out of curiousity, where do I find that debug view?

Debug > View Debugging > Capture View Hierarchy

One solution could be to use edgesForExtendedLayout with the hope:

• it still works with iOS11
• it is compatible with contraints set in the code

[manuroe]

In [RoomViewController viewDidLayoutSubviews], I would try to set self.edgesForExtendedLayout to UIRectEdgeLeft | UIRectEdgeBottom | UIRectEdgeRight in the case of "normal" room header and UIRectEdgeAll in 2 other cases.

[fridtjof]

By the two other cases, you mean the expanded room header and...? I'm not 100% familiar with all the views and UI elements that Riot has (I don't use some features)