Implement social login #3890
Merged
Implement social login #3890
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed to a social login provider.
…ton and apply dedicated theme if needed.
… buttons according to a given array of SSO Identity Providers.
… and ASWebAuthenticationSession.
…espective parameters.
… get a deep link path at the end.
manuroe
requested review from
ismailgulek
and removed request for
ismailgulek,
gileluard and
manuroe
ismailgulek
reviewed
Jan 8, 2021
| override func layoutSubviews() { | ||
| super.layoutSubviews() | ||
|
|
||
| self.layer.cornerRadius = Constants.cornerRadius |
There was a problem hiding this comment.
Is there a reason for not moving this line into commonInit?
| static let redirectURL = "redirectUrl" | ||
| } | ||
|
|
||
| enum Pathes { |
| public typealias SSOAuthentificationSessionCompletionHandler = (URL?, Error?) -> Void | ||
|
|
||
| /// An interface the session uses to ask a delegate for a presentation context. | ||
| protocol SSOAuthenticationSessionContextProviding { |
There was a problem hiding this comment.
Others named as Authentification. Maybe you missed this one. Totally optional.
Co-authored-by: ismailgulek <ismailgulek@users.noreply.github.com>
ismailgulek
approved these changes
Jan 8, 2021
|
This is awesome but I fear many people may get confused with the checkbox. I think it would be good to switch to a standard toggle or checkbox UI element: #3913. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement #3846
Requires matrix-org/matrix-ios-kit#757
This PR can be reviewed in this order: