reliable repro: duplicates in new room list

[colemickens]

Description

I can reliably repro duplicates in the new room list. This repro'd on /develop and now repros on app.element.io.

Steps to reproduce

1. (not sure if necessary) Have a bunch of rooms.
2. it doesn't seem to matter which lists are collapsed or expanded
3. click on a low priority room so that it's visible/active
4. right click on the room, make it a favorite
5. click on any other room
6. expand/look at the favorite list, it will have at least two copies of the newly favorited room.

Often from this point on the list is just broken and requires a reload. Seems like some messy state somewhere.

Version information

• Platform: web (in-browser)

In this screenshot, I did the repro instructions:

1. I was in Rust (lang) (the orange icon).
2. I changed it's priority.
3. It didn't move. It wouldn't move. I collapsed the Favorite list
4. I clicked on an old room i nteh room list.
5. All of the sudden Rust (lang) disappeared from Low Priority
6. I expanded the Favorite list and this is what it looked like:

For the web app:

• Browser: Firefox
• OS: NixOS
• URL: app.element.io

[benparsons]

I am seeing this. I just sent logs against this issue.

I had an issue where an invite did not go away after joining. But then I found that whenever I searched and cleared, that room with the invite would be gradually duplicated in the list. Selecting worked correctly (i.e. when the room was entered, all the duplicates are correctly highlighted).

[turt2live]

@colemickens @benparsons I cannot reproduce this, but can believe it exists as a bug. matrix-org/matrix-react-sdk#5005 adds some logging, and should be on develop.element.io (or tomorrow's nightly) shortly. Please turn on the logging from the labs tab before the issue happens again, then send logs immediately after seeing the problem.

[colemickens]

On first few attempts, I can't repro. The room immediately jumps to the Favorites list as I might expect and there is no duplication. Hopefully it's not a fluke of enabling the logs, heh.

(For what it's worth, I had not been using develop.element.io (didn't know) but had been using riot.im/develop until... mid-day yesterday.)

[benparsons]

I haven't seen this on Element Nightly or develop.element.io in weeks. I vote to close.

[turt2live]

There's at least one rageshake which hasn't been investigated for this, and appears to be reliable.

[williamkray]

i'm seeing this again with the latest spaces beta codebase (my own deployment). rageshake being sent to this issue as i cannot find a more recent version of this but i know it's cropped up again recently. i don't know what i did to trigger it in this case.

[MightyCreak]

Same here, three DM rooms with the same user appeared in my room list. Depending on the selected space, I got two or three duplicated rooms.

[Twi1ightSparkle]

This is now happening several times daily to me. Sometimes so bad that the duplicated room stack up several pages height and it takes a couple of seconds every time I need to scroll past them one way or the other.
It started for me after enabling spaces beta in Element and on my homeserver.

I'm not able to reliable reproduce the issue, and not entirely sure exactly what actions cause it, but it seems to be related to me being active in the room somehow?

It also seem to randomly resolve itself when I'm not looking.

Have rageshaked a couple of times, please let me know if I can provide any other info.

edit: fwiw, most of the repro steps OP posted are not needed for me. It seems to be happening at random, possible in relation to being active in the room, with my "rooms" list, and also saw it with "people" yesterday after sending someone a DM

[pranavmishra90]

Had same issue for the first time. can't reproduce, but I did not follow a similar process as OP.

Windows 10
Element Nightly version: 0.0.1-nightly.2021052201
Synapse 1.34.0
Python 3.8.10

Chat was with a single user over a Whatsapp Bridge. Was not listed as a favorite. Could only expand one of the "3 dot room options" menus. The number of unread messages was inconsistent. Closed Element Nightly and reopened it. Problem fixed.

[ShadowJonathan]

I seem to have found some correlation between search and switching spaces immediately after, I cant give an exact repro, but I think that direction is warm.

[sumnerevans]

Found a (fairly) reliable repro (95+% of the time):

1. Go to a space and select a room.
2. Use the "Filter all spaces" function and search for a room that is not in any space. That is, a room that is only in "Home". For example, a DM with someone who you share no spaces with.
3. Select that room.
4. Profit! (Actually, not really profit, more like cry, but at least you reproduced the bug!)

[williamkray]

i can confirm this triggers the bug for me as well, thanks for putting that one together @sumnerevans!

[callahad]

Toggling the room list appearance options ("Sort by" and "Show rooms with unread messages first") seems to cause already-duplicated rooms to further multiply:

[unclechu]

[ShadowJonathan]

I think i've also found a pretty reliable repro;

1. Go to space X, it has to have at least some rooms in it.
2. search for a room that is not in space X, click it, it should trigger the bug by loading the roompanel with a duplicate of the room you just clicked on. It should also now have you select space Y (which that room was in) or the Home space.
3. Go back to space X, observe the room being "stuck" in the roomlist.
4. Optionally, go to space Z, this space must not contain any rooms, to reset the room lists, and get any duplicate rooms out.

I believe that the additional bugs displayed above are direct results of this one bug, where (accidentally) having a duplicate of another room will make the roomlist controller/logic confused, and will somehow offset/mess up the room list placing, resulting in more duplicates and rooms in unexpected places.

@turt2live Should this issue be renamed, or should this be placed into another issue directly focusing on the problem? So with these latest repros, the work to fix the bug can start.

[unclechu]

Some items are being active at the same time

[ara4n]

I just had a repro of these symptoms; have rageshaked (and have Enable advanced debugging for the room list turned on)

[sumnerevans]

I was still able to reproduce on Element 1.7.33 with the following steps:

1. Go to a space
2. Search for a room that is not in the current space
3. Click on the room that is not in the current space

I have "Show all rooms in Home" turned off (although I think that this repro works with that enabled as well)

Should I create a new issue for this?

[t3chguy]

That screenshot doesn't show any duplicates though?

[t3chguy]

The PR also landed after the RC cut for 1.7.33 - so it won't be in until the following release.

[sumnerevans]

The PR also landed after the RC cut for 1.7.33 - so it won't be in until the following release.

Oh! Sorry! I thought that since the release cut was 4 days ago, that this would be included.

[t3chguy]

RCs tend to happen on Tuesday/Wednesday with the release the following Monday so this was missed (on purpose to give it time for testing)

[ShadowJonathan]

That screenshot doesn't show any duplicates though?

FWIW while screenshot doesn't have a duplicate, it does have a "ghost sticky" which'd show in that room list in every space, and eventually maybe bug out into duplicates. This issue also got fixed, so no need to re-raise it from this description.