Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Filter room/DM input matches unhomoglyphed display name #18409

Open
germain-gg opened this issue Aug 5, 2021 · 2 comments
Open

Filter room/DM input matches unhomoglyphed display name #18409

germain-gg opened this issue Aug 5, 2021 · 2 comments
Labels
A-Room-List A-Timeline-Search O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect Z-Papercuts Visible. Impactful. Predictable to action.

Comments

@germain-gg
Copy link
Contributor

germain-gg commented Aug 5, 2021 •
edited

Steps to reproduce

  • Create a DM with a user called Max
  • Search for "Max" and see the DM show up in the room list
  • Clear the search
  • Search again with the query "rnax"

Expected behaviour

  • No match

Actual Behaviour

  • The user "Max" is matched. This presumably happens because the letter "M" is transformed to "RN" as part of the unhomoglyphication
@germain-gg germain-gg added A-Room-List S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect labels Aug 5, 2021
@t3chguy
Copy link
Member

t3chguy commented Aug 5, 2021

Related to #16477

@t3chguy t3chguy changed the title Filter room/DM input matches disambiguated display name Filter room/DM input matches unhomoglyphed display name Aug 5, 2021
@robintown
Copy link
Member

I guess maybe the unhomoglyph should happen before lowercasing?

@germain-gg germain-gg added the O-Occasional Affects or can be seen by some users regularly or most users rarely label Aug 6, 2021
@kittykat kittykat added A-Timeline-Search Z-Papercuts Visible. Impactful. Predictable to action. labels Aug 27, 2021
@kittykat kittykat mentioned this issue Aug 27, 2021
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Room-List A-Timeline-Search O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect Z-Papercuts Visible. Impactful. Predictable to action.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@kittykat @germain-gg @t3chguy @robintown