Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

all user-settings should be manageable within config.json #23129

Open
boontifex opened this issue Aug 22, 2022 · 1 comment
Open

all user-settings should be manageable within config.json #23129

boontifex opened this issue Aug 22, 2022 · 1 comment
Labels
O-Uncommon Most users are unlikely to come across this or unexpected workflow T-Enhancement X-Needs-Product More input needed from the Product team

Comments

@boontifex
Copy link

Your use case

In my opinion the most options (especially: sendReadReceipts) in user settings should be preset in config.json.

The values should be:

  • force_true: can't be disabled by user
  • *true`: user can disable this option, this setting is enabled by default
  • false: user can enable this option, this setting is disabled by default
  • force_false: can't be enabled by user

Have you considered any alternatives?

To leave the existing boolean logic untouched, the force settings (settingForceDefaults) can be separated:

fe:

{
    "settingDefaults": {
      "breadcrumbs": true,
      "UIFeature.urlPreviews": false
    },
    "settingForceDefaults": {
      "UIFeature.feedback": false
    }
}

Additional context

No response

@dbkr
Copy link
Member

dbkr commented Aug 23, 2022

Currently each setting specifies the level it can be set at, so any settings that can't be set at the config level don't specify so when they're defined.

@dbkr dbkr added X-Needs-Product More input needed from the Product team O-Uncommon Most users are unlikely to come across this or unexpected workflow labels Aug 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
O-Uncommon Most users are unlikely to come across this or unexpected workflow T-Enhancement X-Needs-Product More input needed from the Product team
Projects
None yet
Development

No branches or pull requests

2 participants