Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Element Logo in search bar is filling the complete height #26408

Closed
HarHarLinks opened this issue Oct 20, 2023 · 3 comments · Fixed by matrix-org/matrix-react-sdk#11779
Closed

Element Logo in search bar is filling the complete height #26408

HarHarLinks opened this issue Oct 20, 2023 · 3 comments · Fixed by matrix-org/matrix-react-sdk#11779
Assignees
@germain-gg
Labels
A-Timeline-Search O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect X-Regression X-Release-Blocker

Comments

@HarHarLinks
Copy link

HarHarLinks commented Oct 20, 2023 •
edited by germain-gg

Steps to reproduce

  1. Click on Search icon in new right panel

maybe regressed from matrix-org/matrix-react-sdk#11664 (ping @germain-gg)

Outcome

What did you expect?

normal search header bar

What happened instead?

image

Operating system

arch

Browser information

firefox 118.0.2

URL for webapp

https://develop.element.io

Application version

Element version: 80ba22a-react-f784a085fdfc-js-c0264954eda2 Olm version: 3.2.14

Homeserver

matrix.org

Will you send logs?

No
@HarHarLinks
Copy link
Author

HarHarLinks commented Oct 20, 2023 •
edited

related: #26411

@germain-gg germain-gg mentioned this issue Oct 20, 2023
Merged
3 tasks
@germain-gg germain-gg self-assigned this Oct 20, 2023
@germain-gg
Copy link
Contributor

Unsure i can confirm this has been regressed by matrix-org/matrix-react-sdk#11664 but nonetheless added a fix to bring UI to a sane level again.

@germain-gg germain-gg mentioned this issue Oct 20, 2023
Closed
@t3chguy
Copy link
Member

t3chguy commented Oct 20, 2023 •
edited

Affects staging, regressed by matrix-org/matrix-react-sdk#11741

gabrc52 added a commit to sipb/matrix-react-sdk that referenced this issue Nov 12, 2023
@gabrc52
Merge tag 'v3.84.0' into sipb
5fb7725 
* Knock on a ask-to-join room if a module wants to join the room when navigating to a room ([\matrix-org#11787](matrix-org#11787)). Contributed by @dhenneke.
* Element-R:  Include crypto info in sentry ([\matrix-org#11798](matrix-org#11798)). Contributed by @florianduros.
* Element-R:  Include crypto info in rageshake ([\matrix-org#11797](matrix-org#11797)). Contributed by @florianduros.
* Element-R: Add current version of the rust-sdk and vodozemac ([\matrix-org#11785](matrix-org#11785)). Contributed by @florianduros.
* Fix unfederated invite dialog ([\matrix-org#9618](matrix-org#9618)). Fixes element-hq/element-meta#1466 and element-hq/element-web#22102. Contributed by @owi92.
* New right panel visual language ([\matrix-org#11664](matrix-org#11664)).
* OIDC: add friendly errors ([\matrix-org#11184](matrix-org#11184)). Fixes element-hq/element-web#25665. Contributed by @kerryarchibald.
* Fix rightpanel hiding scrollbar ([\matrix-org#11831](matrix-org#11831)). Contributed by @kerryarchibald.
* Fix multi-tab session lock on Firefox not being cleared ([\matrix-org#11800](matrix-org#11800)). Fixes element-hq/element-web#26165. Contributed by @ManuelHu.
* Deserialise spoilers back into slash command form ([\matrix-org#11805](matrix-org#11805)). Fixes element-hq/element-web#26344.
* Fix Incorrect message scaling for verification request ([\matrix-org#11793](matrix-org#11793)). Fixes element-hq/element-web#24304. Contributed by @capGoblin.
* Fix: Unable to restore a soft-logged-out session established via SSO ([\matrix-org#11794](matrix-org#11794)). Fixes element-hq/element-web#25957. Contributed by @kerryarchibald.
* Use configurable github issue links more consistently ([\matrix-org#11796](matrix-org#11796)).
* Fix io.element.late_event received_ts vs received_at ([\matrix-org#11789](matrix-org#11789)).
* Make invitation dialog scrollable when infos are too long ([\matrix-org#11753](matrix-org#11753)). Contributed by @nurjinjafar.
* Fix spoiler text-align ([\matrix-org#11790](matrix-org#11790)). Contributed by @ajbura.
* Fix: Right panel keeps showing chat when unmaximizing widget.  ([\matrix-org#11697](matrix-org#11697)). Fixes element-hq/element-web#26265. Contributed by @manancodes.
* Fix margin of invite to room button ([\matrix-org#11780](matrix-org#11780)). Fixes element-hq/element-web#26410.
* Update base64 import ([\matrix-org#11784](matrix-org#11784)).
* Set max size for Element logo in search warning ([\matrix-org#11779](matrix-org#11779)). Fixes element-hq/element-web#26408.
* Fix: emoji size in room header topic, remove obsolete emoji style ([\matrix-org#11757](matrix-org#11757)). Fixes element-hq/element-web#26326. Contributed by @kerryarchibald.
* Fix: Bubble layout design is broken ([\matrix-org#11763](matrix-org#11763)). Fixes element-hq/element-web#25818. Contributed by @manancodes.
@florianduros florianduros added S-Major Severely degrades major functionality or product features, with no satisfactory workaround O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience A-Timeline-Search labels Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@germain-gg germain-gg

Labels
A-Timeline-Search O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect X-Regression X-Release-Blocker
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Set max size for Element logo in search warning matrix-org/matrix-react-sdk
4 participants
@germain-gg @t3chguy @florianduros @HarHarLinks