Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Element Call participant limit #23431

Merged
merged 3 commits into from Oct 7, 2022
Merged

Conversation

SimonBrandner
Copy link
Contributor

@SimonBrandner SimonBrandner commented Oct 5, 2022

Requires matrix-org/matrix-react-sdk#9358


Here's what your changelog entry will look like:

✨ Features

  • Add Element Call participant limit (#23431).

Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the sample config doesn't really do anything other than documentation - was this supposed to change the nightly & develop configs?

@SimonBrandner
Copy link
Contributor Author

the sample config doesn't really do anything other than documentation - was this supposed to change the nightly & develop configs?

Since we setup defaults and I assume we'd want to use those on nightly & develop, the change sample config is only documentation

Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be documented in https://github.com/vector-im/element-web/blob/develop/docs/config.md then, not in the sample config

Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
…at/ec-limit

Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
@SimonBrandner SimonBrandner removed the request for review from turt2live October 7, 2022 18:16
@SimonBrandner SimonBrandner merged commit 8891698 into develop Oct 7, 2022
@SimonBrandner SimonBrandner deleted the SimonBrandner/feat/ec-limit branch October 7, 2022 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants