Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always register the pusher when application starts #1579

Merged
merged 1 commit into from
Oct 16, 2023

Conversation

bmarty
Copy link
Member

@bmarty bmarty commented Oct 16, 2023

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

Always register the pusher when application starts, in case the pusher get deleted on the server for some reason...
Also checked: when notification are disabled from the internal settings, the pusher is not unregistered. So there is no risk to enable notification again by registering again the pusher.

Motivation and context

Fix #1481

Screenshots / GIFs

Tests

  • Step 1
  • Step 2
  • Step ...

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

@bmarty bmarty requested a review from a team as a code owner October 16, 2023 08:52
@bmarty bmarty requested review from ganfra and removed request for a team October 16, 2023 08:52
@sonarcloud
Copy link

sonarcloud bot commented Oct 16, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@github-actions
Copy link
Contributor

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/xozVCE

@bmarty bmarty merged commit 2732a79 into develop Oct 16, 2023
15 checks passed
@bmarty bmarty deleted the feature/bma/alwaysRegisterPusher branch October 16, 2023 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Push notifications stopped working
2 participants