Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generic element call link support #1643

Merged
merged 5 commits into from Sep 7, 2023

Conversation

stefanceriu
Copy link
Contributor

This PR adds support for Element Call universal links

  • removes swift-url-routing as it wasn't used and doesn't bring much value on app.element.io links (fragments)
  • replaces ^ with a custom (for the moment trivial) solution
  • parses Call links into AppRoutes and handles them accordingly
  • enable extra background modes to allow the calls to run properly (pending web changes)

@stefanceriu stefanceriu requested a review from a team as a code owner September 6, 2023 13:52
@stefanceriu stefanceriu requested review from pixlwave and removed request for a team September 6, 2023 13:52
@github-actions
Copy link

github-actions bot commented Sep 6, 2023

Warnings
⚠️ Please add a changelog.
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.

Generated by 🚫 Danger Swift against 950c30b

Copy link
Contributor

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, although some comments in there might be quite big changes.

@sonarcloud
Copy link

sonarcloud bot commented Sep 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Sep 7, 2023

Codecov Report

Patch coverage: 7.38% and project coverage change: -0.35% ⚠️

Comparison is base (f1758b5) 58.81% compared to head (950c30b) 58.47%.
Report is 2 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1643      +/-   ##
===========================================
- Coverage    58.81%   58.47%   -0.35%     
===========================================
  Files          411      413       +2     
  Lines        28096    28226     +130     
  Branches     14011    14066      +55     
===========================================
- Hits         16526    16505      -21     
- Misses       11116    11268     +152     
+ Partials       454      453       -1     
Flag Coverage Δ
unittests 22.79% <7.38%> (-0.16%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
ElementX/Sources/Application/AppCoordinator.swift 53.71% <0.00%> (-1.28%) ⬇️
...ication/Navigation/NavigationRootCoordinator.swift 50.00% <0.00%> (-40.48%) ⬇️
.../FlowCoordinators/UserSessionFlowCoordinator.swift 67.78% <0.00%> (-1.56%) ⬇️
...lapsibleFlowLayout/CollapsibleReactionLayout.swift 93.03% <0.00%> (ø)
...ces/Screens/Other/GenericCallLinkCoordinator.swift 0.00% <0.00%> (ø)
...Sources/FlowCoordinators/RoomFlowCoordinator.swift 56.00% <50.00%> (-0.02%) ⬇️
...ntX/Sources/Application/Navigation/AppRoutes.swift 55.55% <55.55%> (ø)

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😎

@stefanceriu stefanceriu merged commit 62b6cd5 into develop Sep 7, 2023
10 checks passed
@stefanceriu stefanceriu deleted the stefan/genericElementCallLinkSupport branch September 7, 2023 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants