-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generic element call link support #1643
Conversation
… It fails parsing the fragments in app.element.io links and it doesn't bring any value
Generated by 🚫 Danger Swift against 950c30b |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, although some comments in there might be quite big changes.
ElementX/Sources/Screens/Other/GenericCallLinkCoordinator.swift
Outdated
Show resolved
Hide resolved
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #1643 +/- ##
===========================================
- Coverage 58.81% 58.47% -0.35%
===========================================
Files 411 413 +2
Lines 28096 28226 +130
Branches 14011 14066 +55
===========================================
- Hits 16526 16505 -21
- Misses 11116 11268 +152
+ Partials 454 453 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 😎
This PR adds support for Element Call universal links
swift-url-routing
as it wasn't used and doesn't bring much value on app.element.io links (fragments)