Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to add email address to HS account without IS set #10637

Closed
jryans opened this issue Aug 23, 2019 · 3 comments

Comments

@jryans
Copy link
Member

commented Aug 23, 2019

At the moment, it is standard for a homeserver to require an identity server to be passed as part of adding an email to your HS account.

This will be changing for future Synapse versions as they learn to manage email themselves, but for the moment it is still the current state.

Riot Web on develop at the moment assumes we've already made it to ideal world, creating the following problem:

  1. Disconnect from your IS in Settings
  2. Try to add an email to your HS account
  3. HS returns 400 error demanding an IS be passed

This can be reproduced on the termstest environment.

@jryans

This comment has been minimized.

Copy link
Member Author

commented Aug 28, 2019

I suppose this is blocked on deciding how the product should function in this case... For old Synapse which requires an IS to be passed for adding an email to your account and you do not have one as you have disconnected from your IS, should we:

a. Show an error and force choosing an IS first (a bit confusing as the Discovery bits are further down in the Settings and not visually related to your HS account info)
b. Use Riot's default IS when talking to an HS that requires one
c. ...something else?

@jryans jryans added the blocked label Aug 28, 2019
@jryans

This comment has been minimized.

Copy link
Member Author

commented Aug 28, 2019

Paging @lampholder for product thoughts.

@lampholder

This comment has been minimized.

Copy link
Member

commented Aug 28, 2019

Already fixed - we only show the 'add email address to account' UX if the hs is properly configured to send emails

@lampholder lampholder closed this Aug 28, 2019
@lampholder lampholder removed the blocked label Aug 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.