Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Autocomplete not showing up reliably #25170

Closed
ZaquMan opened this issue Apr 20, 2023 · 9 comments · Fixed by matrix-org/matrix-react-sdk#10741
Closed

Autocomplete not showing up reliably #25170

ZaquMan opened this issue Apr 20, 2023 · 9 comments · Fixed by matrix-org/matrix-react-sdk#10741
Assignees
@t3chguy
Labels
A-Autocomplete O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect X-Regression X-Release-Blocker

Comments

@ZaquMan
Copy link

ZaquMan commented Apr 20, 2023

Steps to reproduce

  1. Click text field and type @ symbol
  2. Begin typing user's username

image

Outcome

What did you expect?

The list of usernames to reduce to the point of only listing the user who's username was entered after the @ symbol.

What happened instead?

The list of usernames became blank, as if there were no matching users.

Operating system

Windows 10

Application version

Element version: 1.11.29 Olm version: 3.2.12

How did you install the app?

Originally, https://packages.riot.im/desktop/install/win32/x64/Element%20Setup.exe but updates through the app.

Homeserver

https://chat.serverplus.com (Synapse 1.79.0)

Will you send logs?

Yes
@alunturner
Copy link

Hello @ZaquMan , thank you for opening an issue.

Please can you confirm that if, in the above example, you had entered the text @sam there was still nothing shown by the autocomplete? I would expect that to match the "Samuel Lee" user at least. Do you have more information as to which users are present in the rooms and what their names are?

In the screenshot shown, you have entered @sami. The current behaviour, which I believe is the expected behaviour, is that that would not match against "Samuel...", so unless there are users in that room containing the string "sami" in their name, I would expect no matches there.

Perhaps a good step forward would be if you could grab a screen recording of the effect of slowly entering "@sami", with small pauses between the letters to show what the autocomplete does.

@alunturner alunturner added the X-Needs-Info This issue is blocked awaiting information from the reporter label Apr 21, 2023
@ZaquMan
Copy link
Author

ZaquMan commented Apr 21, 2023

Sorry for the lack of detail. The user that was supposed to show up was sami.soomro:serverplus.com, not samuel.lee:serverplus.com. This is an intermittent issue, so it may be difficult to get that recording for you. However as this is affecting multiple users in our organization, I'll ask them to try and catch recordings of it happening.

As for users in the room, there are 29 members of that room:

 @alvin.diolola:serverplus.com  @kyle.fitzgerald:serverplus.com  @michael.turner:serverplus.com  @sami.soomro:serverplus.com
@arslan.james:serverplus.com   @layne:serverplus.com  @monsin.delosreyes:serverplus.com  @samuel.lee:serverplus.com
@christopher.jenkins:serverplus.com   @leanna.esguerra:serverplus.com  @neo:serverplus.com  @SchA:serverplus.com
 @danny.guajardo:serverplus.com  @markjason.landicho:serverplus.com  @nephi.andersen:serverplus.com  @tyler.williams:serverplus.com
 @eli.goodman:serverplus.com  @marktan:serverplus.com  @nick.diolola:serverplus.com  @zachary.barnett:serverplus.com
 @elmer.ferrer:serverplus.com  @mary.parks:serverplus.com  @niquolette.jones:serverplus.com  
 @eric.greenwell:serverplus.com  @maryjane.gayo:serverplus.com  @patricia.hall:serverplus.com  
 @kara.karnes:serverplus.com  @michael.rizzuto:serverplus.com  @robert.folker:serverplus.com  

@alunturner
Copy link

No need to apologise - anything that helps with investigation is appreciated, I've been using this component a lot recently due to some related work but can't say I've seen this behaviour.

Perhaps the request for a video isn't really possible in that case - I didn't understand initially that it's an intermittent issue

@t3chguy
Copy link
Member

t3chguy commented Apr 21, 2023

I've had similar issues but with the emoji autocomplete, where :facep sometimes just doesn't pop up the completer, emptying it and re-typing fixes it. Seems racy. Definitely a regression, no clue when.

@ZaquMan
Copy link
Author

ZaquMan commented Apr 21, 2023

We're having issues with the emojis as well. It might be related, or it might not be, so I was thinking of them as separate issues.

As for when, it seems to have been in the past couple weeks, as the first person to report it to me mentioned before they were unable to reliably click a user's name to mention them. After that was fixed, the issues with autocompleting usernames and emojis began.

@t3chguy t3chguy removed the X-Needs-Info This issue is blocked awaiting information from the reporter label Apr 24, 2023
@scottwallacesh
Copy link

I'm seeing the same issue with @room, any username or emoji/emoticon.

As mentioned, clearing it and re-typing it sees it working again.

@t3chguy t3chguy added X-Regression S-Minor Impairs non-critical functionality or suitable workarounds exist A-Autocomplete O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience labels Apr 25, 2023
@t3chguy t3chguy changed the title Users not showing up when typing @username Autocomplete not showing up reliably Apr 26, 2023
@t3chguy t3chguy mentioned this issue Apr 26, 2023
Closed
@alunturner
Copy link

alunturner commented Apr 28, 2023 •
edited
Loading

I've found some steps to reproduce for this (there may be others). Would appreciate if you could try these steps @ZaquMan to see if it reproduces this way for you too. This was testing on develop on 28 Apr:

STR:

  • enter some text to open the autocomplete (could be mention or emoji, doesn't matter)
  • pick something from the autocomplete
  • send the message
  • now try to open the same autocomplete by entering text
  • autocomplete will not open

Interestingly it seems that sending a purely text message followed by trying to open the emoji picker also blocks that autocomplete opening (but this isn't the case for user mentions). See second video. In both videos, to get it to work I press backspace until the placeholder appears (as noted as a workaround in the comments above).

Video of following STR:

trimmed.video.mov

Video of specific emoji behaviour:

Screen.Recording.2023-04-28.at.10.23.56.mov

@t3chguy
Copy link
Member

t3chguy commented Apr 28, 2023

@alunturner I can reproduce using those steps, thanks

@t3chguy t3chguy self-assigned this Apr 28, 2023
@t3chguy
Copy link
Member

t3chguy commented Apr 28, 2023

Regressed by matrix-org/matrix-react-sdk@e4dfb21

@t3chguy t3chguy mentioned this issue Apr 28, 2023
Merged
@t3chguy t3chguy mentioned this issue May 9, 2023
Closed
su-ex added a commit to SchildiChat/element-desktop that referenced this issue Jul 31, 2023
@su-ex
Merge tag 'v1.11.31' into sc
2a1c93d 
* If you package Element Desktop with a static sqlcipher, you may need to tweak some build scripts: SQLCIPHER_STATIC became SQLCIPHER_BUNDLED, and OpenSSL is now included too.
* Start packaging for Debian & Ubuntu aarch64 ([\element-hq#895](element-hq#895)).
* Use a fully static seshat build ([\element-hq#631](element-hq#631)). Contributed by @MatMaul.
* Improve Content-Security-Policy ([\#25210](element-hq/element-web#25210)).
* Add UIFeature.locationSharing to hide location sharing ([\#10727](matrix-org/matrix-react-sdk#10727)).
* Memoize field validation results ([\#10714](matrix-org/matrix-react-sdk#10714)).
* Commands for plain text editor ([\#10567](matrix-org/matrix-react-sdk#10567)). Contributed by @alunturner.
* Allow 16 lines of text in the rich text editors ([\#10670](matrix-org/matrix-react-sdk#10670)). Contributed by @alunturner.
* Bail out of `RoomSettingsDialog` when room is not found ([\#10662](matrix-org/matrix-react-sdk#10662)). Contributed by @kerryarchibald.
* Element-R: Populate device list for right-panel ([\#10671](matrix-org/matrix-react-sdk#10671)). Contributed by @florianduros.
* Make existing and new issue URLs configurable ([\#10710](matrix-org/matrix-react-sdk#10710)). Fixes element-hq/element-web#24424.
* Fix usages of ARIA tabpanel ([\#10628](matrix-org/matrix-react-sdk#10628)). Fixes element-hq/element-web#25016.
* Element-R: Starting a DMs with a user ([\#10673](matrix-org/matrix-react-sdk#10673)). Contributed by @florianduros.
* ARIA Accessibility improvements ([\#10675](matrix-org/matrix-react-sdk#10675)).
* ARIA Accessibility improvements ([\#10674](matrix-org/matrix-react-sdk#10674)).
* Add arrow key controls to emoji and reaction pickers ([\#10637](matrix-org/matrix-react-sdk#10637)). Fixes element-hq/element-web#17189.
* Translate credits in help about section ([\#10676](matrix-org/matrix-react-sdk#10676)).
* Fix macos update check exploding ([\element-hq#944](element-hq#944)). Fixes element-hq#668.
* Fix: reveal images when image previews are disabled ([\#10781](matrix-org/matrix-react-sdk#10781)). Fixes element-hq/element-web#25271. Contributed by @kerryarchibald.
* Workaround Squirrel.Mac wedging app restart after failed update check ([\element-hq#629](element-hq#629)).
* Fix autocomplete not resetting properly on message send ([\#10741](matrix-org/matrix-react-sdk#10741)). Fixes element-hq/element-web#25170.
* Fix start_sso not working with guests disabled ([\#10720](matrix-org/matrix-react-sdk#10720)). Fixes element-hq/element-web#16624.
* Fix soft crash with Element call widgets ([\#10684](matrix-org/matrix-react-sdk#10684)).
* Send correct receipt when marking a room as read ([\#10730](matrix-org/matrix-react-sdk#10730)). Fixes element-hq/element-web#25207.
* Offload some more waveform processing onto a worker ([\#9223](matrix-org/matrix-react-sdk#9223)). Fixes element-hq/element-web#19756.
* Consolidate login errors ([\#10722](matrix-org/matrix-react-sdk#10722)). Fixes element-hq/element-web#17520.
* Fix all rooms search generating permalinks to wrong room id ([\#10625](matrix-org/matrix-react-sdk#10625)). Fixes element-hq/element-web#25115.
* Posthog properly handle Analytics ID changing from under us ([\#10702](matrix-org/matrix-react-sdk#10702)). Fixes element-hq/element-web#25187.
* Fix Clock being read as an absolute time rather than duration ([\#10706](matrix-org/matrix-react-sdk#10706)). Fixes element-hq/element-web#22582.
* Properly translate errors in `ChangePassword.tsx` so they show up translated to the user but not in our logs ([\#10615](matrix-org/matrix-react-sdk#10615)). Fixes element-hq/element-web#9597. Contributed by @MadLittleMods.
* Honour feature toggles in guest mode ([\#10651](matrix-org/matrix-react-sdk#10651)). Fixes element-hq/element-web#24513. Contributed by @andybalaam.
* Fix default content in devtools event sender ([\#10699](matrix-org/matrix-react-sdk#10699)). Contributed by @tulir.
* Fix a crash when a call ends while you're in it ([\#10681](matrix-org/matrix-react-sdk#10681)). Fixes element-hq/element-web#25153.
* Fix lack of screen reader indication when triggering auto complete ([\#10664](matrix-org/matrix-react-sdk#10664)). Fixes element-hq/element-web#11011.
* Fix typing tile duplicating users ([\#10678](matrix-org/matrix-react-sdk#10678)). Fixes element-hq/element-web#25165.
* Fix wrong room topic tooltip position ([\#10667](matrix-org/matrix-react-sdk#10667)). Fixes element-hq/element-web#25158.
* Fix create subspace dialog not working ([\#10652](matrix-org/matrix-react-sdk#10652)). Fixes element-hq/element-web#24882.
su-ex added a commit to SchildiChat/element-web that referenced this issue Jul 31, 2023
@su-ex
Merge tag 'v1.11.31' into sc
01d58ef 
* Improve Content-Security-Policy ([\element-hq#25210](element-hq#25210)).
* Add UIFeature.locationSharing to hide location sharing ([\element-hq#10727](matrix-org/matrix-react-sdk#10727)).
* Memoize field validation results ([\#10714](matrix-org/matrix-react-sdk#10714)).
* Commands for plain text editor ([\element-hq#10567](matrix-org/matrix-react-sdk#10567)). Contributed by @alunturner.
* Allow 16 lines of text in the rich text editors ([\element-hq#10670](matrix-org/matrix-react-sdk#10670)). Contributed by @alunturner.
* Bail out of `RoomSettingsDialog` when room is not found ([\#10662](matrix-org/matrix-react-sdk#10662)). Contributed by @kerryarchibald.
* Element-R: Populate device list for right-panel ([\element-hq#10671](matrix-org/matrix-react-sdk#10671)). Contributed by @florianduros.
* Make existing and new issue URLs configurable ([\element-hq#10710](matrix-org/matrix-react-sdk#10710)). Fixes element-hq#24424.
* Fix usages of ARIA tabpanel ([\element-hq#10628](matrix-org/matrix-react-sdk#10628)). Fixes element-hq#25016.
* Element-R: Starting a DMs with a user ([\element-hq#10673](matrix-org/matrix-react-sdk#10673)). Contributed by @florianduros.
* ARIA Accessibility improvements ([\element-hq#10675](matrix-org/matrix-react-sdk#10675)).
* ARIA Accessibility improvements ([\element-hq#10674](matrix-org/matrix-react-sdk#10674)).
* Add arrow key controls to emoji and reaction pickers ([\element-hq#10637](matrix-org/matrix-react-sdk#10637)). Fixes element-hq#17189.
* Translate credits in help about section ([\element-hq#10676](matrix-org/matrix-react-sdk#10676)).
* Fix: reveal images when image previews are disabled ([\element-hq#10781](matrix-org/matrix-react-sdk#10781)). Fixes element-hq#25271. Contributed by @kerryarchibald.
* Fix autocomplete not resetting properly on message send ([\element-hq#10741](matrix-org/matrix-react-sdk#10741)). Fixes element-hq#25170.
* Fix start_sso not working with guests disabled ([\element-hq#10720](matrix-org/matrix-react-sdk#10720)). Fixes element-hq#16624.
* Fix soft crash with Element call widgets ([\element-hq#10684](matrix-org/matrix-react-sdk#10684)).
* Send correct receipt when marking a room as read ([\element-hq#10730](matrix-org/matrix-react-sdk#10730)). Fixes element-hq#25207.
* Offload some more waveform processing onto a worker ([\element-hq#9223](matrix-org/matrix-react-sdk#9223)). Fixes element-hq#19756.
* Consolidate login errors ([\element-hq#10722](matrix-org/matrix-react-sdk#10722)). Fixes element-hq#17520.
* Fix all rooms search generating permalinks to wrong room id ([\element-hq#10625](matrix-org/matrix-react-sdk#10625)). Fixes element-hq#25115.
* Posthog properly handle Analytics ID changing from under us ([\element-hq#10702](matrix-org/matrix-react-sdk#10702)). Fixes element-hq#25187.
* Fix Clock being read as an absolute time rather than duration ([\element-hq#10706](matrix-org/matrix-react-sdk#10706)). Fixes element-hq#22582.
* Properly translate errors in `ChangePassword.tsx` so they show up translated to the user but not in our logs ([\element-hq#10615](matrix-org/matrix-react-sdk#10615)). Fixes element-hq#9597. Contributed by @MadLittleMods.
* Honour feature toggles in guest mode ([\element-hq#10651](matrix-org/matrix-react-sdk#10651)). Fixes element-hq#24513. Contributed by @andybalaam.
* Fix default content in devtools event sender ([\element-hq#10699](matrix-org/matrix-react-sdk#10699)). Contributed by @tulir.
* Fix a crash when a call ends while you're in it ([\element-hq#10681](matrix-org/matrix-react-sdk#10681)). Fixes element-hq#25153.
* Fix lack of screen reader indication when triggering auto complete ([\element-hq#10664](matrix-org/matrix-react-sdk#10664)). Fixes element-hq#11011.
* Fix typing tile duplicating users ([\element-hq#10678](matrix-org/matrix-react-sdk#10678)). Fixes element-hq#25165.
* Fix wrong room topic tooltip position ([\element-hq#10667](matrix-org/matrix-react-sdk#10667)). Fixes element-hq#25158.
* Fix create subspace dialog not working ([\element-hq#10652](matrix-org/matrix-react-sdk#10652)). Fixes element-hq#24882.
su-ex added a commit to SchildiChat/matrix-react-sdk that referenced this issue Jul 31, 2023
@su-ex
Merge tag 'v3.72.0' into sc
fede380 
* Add UIFeature.locationSharing to hide location sharing ([\matrix-org#10727](matrix-org#10727)).
* Memoize field validation results ([\matrix-org#10714](matrix-org#10714)).
* Commands for plain text editor ([\matrix-org#10567](matrix-org#10567)). Contributed by @alunturner.
* Allow 16 lines of text in the rich text editors ([\matrix-org#10670](matrix-org#10670)). Contributed by @alunturner.
* Bail out of `RoomSettingsDialog` when room is not found ([\matrix-org#10662](matrix-org#10662)). Contributed by @kerryarchibald.
* Element-R: Populate device list for right-panel ([\matrix-org#10671](matrix-org#10671)). Contributed by @florianduros.
* Make existing and new issue URLs configurable ([\matrix-org#10710](matrix-org#10710)). Fixes element-hq/element-web#24424.
* Fix usages of ARIA tabpanel ([\matrix-org#10628](matrix-org#10628)). Fixes element-hq/element-web#25016.
* Element-R: Starting a DMs with a user ([\matrix-org#10673](matrix-org#10673)). Contributed by @florianduros.
* ARIA Accessibility improvements ([\matrix-org#10675](matrix-org#10675)).
* ARIA Accessibility improvements ([\matrix-org#10674](matrix-org#10674)).
* Add arrow key controls to emoji and reaction pickers ([\matrix-org#10637](matrix-org#10637)). Fixes element-hq/element-web#17189.
* Translate credits in help about section ([\matrix-org#10676](matrix-org#10676)).
* Fix: reveal images when image previews are disabled ([\matrix-org#10781](matrix-org#10781)). Fixes element-hq/element-web#25271. Contributed by @kerryarchibald.
* Fix autocomplete not resetting properly on message send ([\matrix-org#10741](matrix-org#10741)). Fixes element-hq/element-web#25170.
* Fix start_sso not working with guests disabled ([\matrix-org#10720](matrix-org#10720)). Fixes element-hq/element-web#16624.
* Fix soft crash with Element call widgets ([\matrix-org#10684](matrix-org#10684)).
* Send correct receipt when marking a room as read ([\matrix-org#10730](matrix-org#10730)). Fixes element-hq/element-web#25207.
* Offload some more waveform processing onto a worker ([\matrix-org#9223](matrix-org#9223)). Fixes element-hq/element-web#19756.
* Consolidate login errors ([\matrix-org#10722](matrix-org#10722)). Fixes element-hq/element-web#17520.
* Fix all rooms search generating permalinks to wrong room id ([\matrix-org#10625](matrix-org#10625)). Fixes element-hq/element-web#25115.
* Posthog properly handle Analytics ID changing from under us ([\matrix-org#10702](matrix-org#10702)). Fixes element-hq/element-web#25187.
* Fix Clock being read as an absolute time rather than duration ([\matrix-org#10706](matrix-org#10706)). Fixes element-hq/element-web#22582.
* Properly translate errors in `ChangePassword.tsx` so they show up translated to the user but not in our logs ([\matrix-org#10615](matrix-org#10615)). Fixes element-hq/element-web#9597. Contributed by @MadLittleMods.
* Honour feature toggles in guest mode ([\matrix-org#10651](matrix-org#10651)). Fixes element-hq/element-web#24513. Contributed by @andybalaam.
* Fix default content in devtools event sender ([\matrix-org#10699](matrix-org#10699)). Contributed by @tulir.
* Fix a crash when a call ends while you're in it ([\matrix-org#10681](matrix-org#10681)). Fixes element-hq/element-web#25153.
* Fix lack of screen reader indication when triggering auto complete ([\matrix-org#10664](matrix-org#10664)). Fixes element-hq/element-web#11011.
* Fix typing tile duplicating users ([\matrix-org#10678](matrix-org#10678)). Fixes element-hq/element-web#25165.
* Fix wrong room topic tooltip position ([\matrix-org#10667](matrix-org#10667)). Fixes element-hq/element-web#25158.
* Fix create subspace dialog not working ([\matrix-org#10652](matrix-org#10652)). Fixes element-hq/element-web#24882.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@t3chguy t3chguy

Labels
A-Autocomplete O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect X-Regression X-Release-Blocker
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix autocomplete not resetting properly on message send matrix-org/matrix-react-sdk
4 participants
@scottwallacesh @t3chguy @ZaquMan @alunturner