Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ssss key entry doesn't proceed #12288

Closed
foldleft opened this issue Feb 7, 2020 · 7 comments
Closed

ssss key entry doesn't proceed #12288

foldleft opened this issue Feb 7, 2020 · 7 comments

Comments

@foldleft
Copy link
Contributor

foldleft commented Feb 7, 2020

when trying to verify another user, I couldn't get the ssss key entry to accept my key

@foldleft
Copy link
Contributor Author

this doesn't affect me on staging so I think it's something peculiar to my env

@foldleft
Copy link
Contributor Author

does affect me on riot.im/develop though, looks like a regression then?

@jryans
Copy link
Collaborator

jryans commented Feb 10, 2020

@foldleft, hmm, well on staging and app, cross-signing is not enabled, so I would have thought you wouldn't even reach the SSSS prompts there?

@foldleft
Copy link
Contributor Author

it's even on key backup prompts

@jryans jryans added the phase:2 label Feb 10, 2020
foldleft added a commit to matrix-org/matrix-react-sdk that referenced this issue Feb 11, 2020
@foldleft foldleft self-assigned this Feb 11, 2020
foldleft added a commit to matrix-org/matrix-react-sdk that referenced this issue Feb 11, 2020
@foldleft
Copy link
Contributor Author

Okay, looks like either one or two bugs!

  1. the input dialog wasn't providing feedback properly if the key was invalid
  2. (still to investigate) possibly checkPrivateKey isn't behaving properly; possibly I've broken my cross-signing state

@foldleft
Copy link
Contributor Author

Also I note there's a flow from AccessSecretStorageDialog for recovering secret storage, that we may wish to contemplate adding

@foldleft
Copy link
Contributor Author

yep that was it, i broke my own state

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants