Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Riot duplicates calls to Scalar #5846

Closed
turt2live opened this issue Dec 17, 2017 · 3 comments · Fixed by matrix-org/matrix-react-sdk#3115

Comments

@turt2live
Copy link
Member

commented Dec 17, 2017

Description

Riot sends two /register requests very close together when opening Riot to a room. The first is the normal register for the manage integrations button check, however the second appears to be coming from the AppTile getting set up. Although it's not really a huge issue, it's causing uneeded duplicate data in the integration manager and homeserver (by requesting 2 sets of open ID tokens).

Version information

  • Platform: web (in-browser)
  • Browser: Chrome 63
  • OS: Windows 10
  • URL: riot.im/develop
@turt2live turt2live changed the title Riot sends two /register requests to Scalar Riot duplicates calls to Scalar Dec 18, 2017
@turt2live

This comment has been minimized.

Copy link
Member Author

commented Dec 18, 2017

Updated title, it's also affecting /account and probably others:

Dec-17-2017 17:14:02.366 -07:00 verbose [Webserver] Incoming request: GET /api/v1/scalar/account?scalar_token=redacted
Dec-17-2017 17:14:02.465 -07:00 verbose [Webserver] Incoming request: GET /api/v1/scalar/account?scalar_token=redacted
@turt2live

This comment has been minimized.

Copy link
Member Author

commented May 15, 2018

This seems to have gotten worse now. It makes three requests every time someone changes rooms. Luckily it's a highly cachable endpoint, but something doesn't smell good considering the number of requests it's making.

@ara4n

This comment has been minimized.

Copy link
Member

commented Jun 13, 2019

we shouldn't be calling /account for every room either, should we?

@lampholder lampholder added 🔥 Fire 🔥 p1 and removed p2 labels Jun 17, 2019
@lampholder lampholder added this to In Progress in Workflow via automation Jun 17, 2019
@lampholder lampholder moved this from In Progress to Raging Inferno 🔥🔥🔥 in Workflow Jun 17, 2019
@turt2live turt2live moved this from Raging Inferno 🔥🔥🔥 to In Progress in Workflow Jun 17, 2019
@turt2live turt2live self-assigned this Jun 17, 2019
@turt2live turt2live moved this from In Progress to In Review in Workflow Jun 17, 2019
Workflow automation moved this from In Review to In Test Jun 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Workflow
In Test
4 participants
You can’t perform that action at this time.