Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apparently npm i && npm start doesn't work on develop or experimental atm #7956

Closed
ara4n opened this issue Dec 26, 2018 · 5 comments
Closed
Labels
T-Task Tasks for the team like planning X-Needs-Info This issue is blocked awaiting information from the reporter

Comments

@ara4n
Copy link
Member

ara4n commented Dec 26, 2018

we need to CI these surely, and remember to repoint the deps in package.json or whatever is going wrong

@lampholder
Copy link
Member

Do you mean it doesn't work after following the dev environment setup instructions?

How does the build happen for CI?

@lampholder lampholder added X-Needs-Info This issue is blocked awaiting information from the reporter T-Task Tasks for the team like planning labels Jan 2, 2019
@lampholder
Copy link
Member

It worked for me building /develop this morning

@ara4n
Copy link
Member Author

ara4n commented Jan 3, 2019

this was @martindale complaining of build errors when trying to run npm i && npm start on a develop checkout of riot-web. The theory is that the dep on matrix-react-sdk hadn't been unpinned to develop, so it was trying to use the wrong matrix-react-sdk. Dunno if someone fixed it since or if something else was wrong.

the discussion subsequently slid into a "why is the majority of the app in a library" discussion.

@jryans
Copy link
Collaborator

jryans commented Jan 3, 2019

I believe #7728 describes a potential way to fix the cause of this.

@jryans
Copy link
Collaborator

jryans commented Jan 2, 2020

We now set the deps back to develop after release, so I believe this should be fixed now.

@jryans jryans closed this as completed Jan 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-Task Tasks for the team like planning X-Needs-Info This issue is blocked awaiting information from the reporter
Projects
None yet
Development

No branches or pull requests

3 participants