Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

If HS registration is disabled, errors trying to register are awful #8334

Closed
ara4n opened this issue Jan 31, 2019 · 5 comments
Closed

If HS registration is disabled, errors trying to register are awful #8334

ara4n opened this issue Jan 31, 2019 · 5 comments
Assignees
@jryans
Labels
A-Authentication A-Registration P1 S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect X-Regression

Comments

@ara4n
Copy link
Member

ara4n commented Jan 31, 2019 •
edited
Loading

You get an error of "Unable to query for supported registration methods" rather than "this homeserver has registration disabled"
@lampholder
Copy link
Member

We should check the new flow against standard modular configs (e.g. required email address), too

@lampholder lampholder added T-Defect P1 S-Major Severely degrades major functionality or product features, with no satisfactory workaround A-Registration labels Jan 31, 2019
@lampholder
Copy link
Member

The /app behaviour is also problematic.

  • go to register
  • choose 'custom server'
  • start typing in the Home server URL (why is there a space there?????)
  • if you type too slowly it polls https://partofadomainna/register, gets an error, and (on my macbook air) displays that error below the fold
  • if you complete typing a HS URL for an HS with registration disabled, it gets back the registration disabled state in the json payload, and doesn't tell the user
  • user is left to enter their registration details with no hope of success
  • registration fails, error displayed beneath the fold

@jryans
Copy link
Collaborator

jryans commented Jan 31, 2019

This is a regression with the new flow on /develop? A screenshot would help, but I can try to recreate as well.

@bwindels bwindels mentioned this issue Jan 31, 2019
Closed
41 tasks
@jryans
Copy link
Collaborator

jryans commented Jan 31, 2019

This is a regression with the new flow on /develop? A screenshot would help, but I can try to recreate as well.

Yes, it's a regression. @lampholder supplied this from /app:

image

@jryans jryans self-assigned this Jan 31, 2019
@jryans jryans mentioned this issue Jan 31, 2019
Merged
@jryans
Copy link
Collaborator

jryans commented Feb 1, 2019

Fixed by matrix-org/matrix-react-sdk#2548.

@jryans jryans closed this as completed Feb 1, 2019
@aaronraimist aaronraimist mentioned this issue Jun 1, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jryans jryans

Labels
A-Authentication A-Registration P1 S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect X-Regression
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jryans @ara4n @lampholder