Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Room Directory and Chat with Riot Biot from welcome broken when HS disables guest access #9546

Closed
jryans opened this issue Apr 23, 2019 · 1 comment · Fixed by #9957
Closed

Comments

@jryans
Copy link
Collaborator

jryans commented Apr 23, 2019

If the default HS for your Riot install has guest access disabled (allow_guest_access: False), then both the "Chat with Riot Bot" and "Room Directory" actions will fail quite badly:

  • Chat with Riot Bot silently does nothing
  • Room Directory opens a model an infinite spinner:

image

@turt2live
Copy link
Member

We should just hide these options when we can't register a guest imo

Or provide a config option to hide the whole section.

@turt2live turt2live self-assigned this Jun 4, 2019
@turt2live turt2live added this to In Progress in Web App Team via automation Jun 4, 2019
@turt2live turt2live moved this from In Progress to In Review in Web App Team Jun 4, 2019
Web App Team automation moved this from In Review to In Test Jun 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants