Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable cross-signing on /develop #12126

Merged
merged 1 commit into from Jan 29, 2020
Merged

Enable cross-signing on /develop #12126

merged 1 commit into from Jan 29, 2020

Conversation

@t3chguy
Copy link
Collaborator

t3chguy commented Jan 29, 2020

No description provided.

@t3chguy t3chguy requested a review from vector-im/riot-web Jan 29, 2020
Copy link
Member

turt2live left a comment

lgtm as a change, barring discussions regarding whether this is a good idea

I can't deploy this one

@jryans jryans added this to In Review in Workflow Jan 29, 2020
@jryans

This comment has been minimized.

Copy link
Member

jryans commented Jan 29, 2020

Waiting for internal alignment that we've polished things enough for exposure to develop.

@jryans

This comment has been minimized.

Copy link
Member

jryans commented Jan 29, 2020

This is blocked on clarifying device name, ID in toasts, as well as changing to devices -> sessions in Settings copy (will PR now).

@t3chguy

This comment has been minimized.

Copy link
Collaborator Author

t3chguy commented Jan 29, 2020

@jryans

This comment has been minimized.

Copy link
Member

jryans commented Jan 29, 2020

@jryans

This comment has been minimized.

Copy link
Member

jryans commented Jan 29, 2020

Blocked PRs completed, waiting for CI to push them live on develop.

@jryans

This comment has been minimized.

Copy link
Member

jryans commented Jan 29, 2020

I'll merge this now, and wait to deploy once develop is confirmed ready.

@jryans jryans merged commit 98b8ba2 into develop Jan 29, 2020
7 checks passed
7 checks passed
buildkite/riot-web Build #1877 passed (6 minutes, 10 seconds)
Details
buildkite/riot-web/build Passed (5 minutes, 56 seconds)
Details
buildkite/riot-web/eslint-js-lint Passed (3 minutes, 45 seconds)
Details
buildkite/riot-web/eslint-types-lint Passed (57 seconds)
Details
buildkite/riot-web/i18n Passed (3 minutes, 42 seconds)
Details
buildkite/riot-web/jest-tests Passed (4 minutes, 19 seconds)
Details
buildkite/riot-web/pipeline Passed (4 seconds)
Details
Workflow automation moved this from In Review to In Test Jan 29, 2020
@jryans

This comment has been minimized.

Copy link
Member

jryans commented Jan 30, 2020

This is now live on develop! 🎉

@jryans jryans added the phase:1 label Feb 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Workflow
In Test
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.