Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace device with session in UI text #3980

Merged
merged 2 commits into from
Jan 29, 2020
Merged

Replace device with session in UI text #3980

merged 2 commits into from
Jan 29, 2020

Conversation

jryans
Copy link
Collaborator

@jryans jryans commented Jan 29, 2020

This replaces "device" with "session" throughout user-visible text at the React
layer. Variable names and comments are left as-is for now.

This replaces "device" with "session" throughout user-visible text at the React
layer. Variable names and comments are left as-is for now.
src/Analytics.js Outdated Show resolved Hide resolved
@jryans jryans requested a review from a team January 29, 2020 16:16
Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you also prunei18n please?

@jryans
Copy link
Collaborator Author

jryans commented Jan 29, 2020

Yes, will do separately after locking and merging Weblate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants