Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Developer tool: convert rageshake error locations back to sourcecode locations #13357

Merged
merged 2 commits into from
May 1, 2020
Merged

Developer tool: convert rageshake error locations back to sourcecode locations #13357

merged 2 commits into from
May 1, 2020

Conversation

foldleft
Copy link
Contributor

@foldleft foldleft commented Apr 24, 2020 •
edited
Loading

Land second

fixes: #13359

@foldleft foldleft requested a review from a team April 24, 2020 08:56
@foldleft foldleft requested a review from jryans April 28, 2020 08:53
jryans
jryans previously approved these changes Apr 28, 2020
View reviewed changes
Copy link
Collaborator

@jryans jryans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes here generally seem fine, but I am currently still a bit puzzled about why the React SDK layer. Anyway, we'll resolve that on the main PR, and this can be updated if it moves.

scripts/copy-res.js Outdated Show resolved Hide resolved
@foldleft foldleft changed the title Turn on source mapping, copy decoder-ring over to bundle Developer tool: convert rageshake error locations back to sourcecode locations Apr 30, 2020
@foldleft foldleft requested a review from a team April 30, 2020 13:02
@foldleft foldleft requested review from jryans and removed request for jryans April 30, 2020 16:07
@turt2live turt2live requested review from turt2live and removed request for a team April 30, 2020 16:29
@turt2live turt2live dismissed jryans’s stale review April 30, 2020 16:30

significant changes since approval

turt2live
turt2live approved these changes Apr 30, 2020
View reviewed changes
Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall seems fine. We should have an issue to track getting it into the webpack build proper

res/decoder-ring/datatypes.js
Comment on lines +97 to +99
static of(reason, opt) {
return new FetchError(reason, opt);
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

static functions should be at the end of the class

@foldleft foldleft merged commit 0e75b1b into develop May 1, 2020
@foldleft foldleft deleted the foldleft/decoder-ring branch May 1, 2020 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jryans jryans jryans left review comments

@turt2live turt2live turt2live approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

A tool for turning rageshake tracebacks into actual code locations
3 participants
@foldleft @jryans @turt2live