Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify that HTTPS is not just needed for VoIP #6146

Merged
merged 6 commits into from Sep 1, 2019

Conversation

@rugk
Copy link
Contributor

rugk commented Feb 15, 2018

…but for basic security.

…but for basic security.
@MTRNord

This comment has been minimized.

Copy link
Contributor

MTRNord commented Feb 15, 2018

The pr should go against the develop branch.

@rugk rugk changed the base branch from master to develop Feb 15, 2018
README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@jonathancross

This comment has been minimized.

Copy link

jonathancross commented Aug 27, 2019

Ping @rugk still have a comment not responded to.

In addition to fixes from review, also add link to official source with more information.
@rugk

This comment has been minimized.

Copy link
Contributor Author

rugk commented Aug 27, 2019

Sorry, seems I've missed the notifications. 😄

Finally, improved/fixed.

@turt2live turt2live requested a review from vector-im/riot-web Aug 27, 2019
@turt2live turt2live added this to In Review in Workflow Aug 27, 2019
Copy link
Member

turt2live left a comment

Thanks for rewording this

README.md Outdated Show resolved Hide resolved
@jryans

This comment has been minimized.

Copy link
Member

jryans commented Aug 29, 2019

@rugk If you have time to apply the suggestion above or mark the PR so that maintainers can edit and do so, then I believe we can press the merge button after that. 😁

Co-Authored-By: Travis Ralston <travpc@gmail.com>
@rugk

This comment has been minimized.

Copy link
Contributor Author

rugk commented Sep 1, 2019

Done. FYI "Allow edits from maintainers." had already been aliowed/selected.

@turt2live

This comment has been minimized.

Copy link
Member

turt2live commented Sep 1, 2019

for some reason it was blocking me from doing both in and out of github :(

Thanks!

@turt2live turt2live merged commit f97b632 into vector-im:develop Sep 1, 2019
Workflow automation moved this from In Review to In Test Sep 1, 2019
@rugk rugk deleted the rugk:patch-1 branch Sep 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
6 participants
You can’t perform that action at this time.