Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix themeing bug with Firefox where "disabled" ignored #6301

Merged
merged 1 commit into from Mar 12, 2018

Conversation

@lukebarnard1
Copy link
Contributor

lukebarnard1 commented Mar 12, 2018

A bug in firefox means "disabled" isn't honoured when set in the
HTML. Doing a.disabled = false does work however, and Chrome
also appears to honour this.

Fixes #6075

A bug in firefox means "disabled" isn't honoured when set in the
HTML. Doing `a.disabled = false` does work however, and Chrome
also appears to honour this.
@turt2live

This comment has been minimized.

Copy link
Member

turt2live commented Mar 12, 2018

Is this to fix #6075 by chance?

@lukebarnard1

This comment has been minimized.

Copy link
Contributor Author

lukebarnard1 commented Mar 12, 2018

Is this to fix #6075 by chance?

Yes :)

@dbkr

This comment has been minimized.

Copy link
Member

dbkr commented Mar 12, 2018

lgtm. @ara4n may want to take a look too

@dbkr dbkr assigned ara4n and unassigned dbkr Mar 12, 2018
@ara4n

This comment has been minimized.

Copy link
Member

ara4n commented Mar 12, 2018

if it works on Chrome and Safari too, i'm happy.

@lukebarnard1

This comment has been minimized.

Copy link
Contributor Author

lukebarnard1 commented Mar 12, 2018

@dbkr reports this working in Safari

@lukebarnard1 lukebarnard1 merged commit 5eae913 into develop Mar 12, 2018
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@ara4n

This comment has been minimized.

Copy link
Member

ara4n commented Mar 12, 2018

\o/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.