Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate default homeserver config before loading the app #9496

Merged
merged 10 commits into from
May 10, 2019
Merged

Validate default homeserver config before loading the app #9496

merged 10 commits into from
May 10, 2019

Commits on May 3, 2019

  1. Validate default homeserver config before loading the app 

    Implements the process described here: #9290 (comment)

The expectation is that later layers (like the react-sdk) will make use of the `validated_discovery_config` option instead of interpreting the config themselves.

We intentionally block the UI from loading here to avoid races between discovery and the app loading.
    @turt2live
    turt2live committed May 3, 2019
    Configuration menu
    Copy the full SHA
    f08491c View commit details
    Browse the repository at this point in the history

  2. Use new js-sdk properties for getting discovery errors 

    Requires matrix-org/matrix-js-sdk#899
    @turt2live
    turt2live committed May 3, 2019
    Configuration menu
    Copy the full SHA
    5445632 View commit details
    Browse the repository at this point in the history

  3. Add note to self

    @turt2live
    turt2live committed May 3, 2019
    Configuration menu
    Copy the full SHA
    51941ea View commit details
    Browse the repository at this point in the history

  4. Move bulk of discovery processing to react-sdk

    @turt2live
    turt2live committed May 3, 2019
    Configuration menu
    Copy the full SHA
    c8caf67 View commit details
    Browse the repository at this point in the history

  5. Don't repackage the ValidatedDiscoveryConfig 

    It's usable as-is, and we can add things to it when we need to (ie: integrations).
    @turt2live
    turt2live committed May 3, 2019
    Configuration menu
    Copy the full SHA
    e7bf643 View commit details
    Browse the repository at this point in the history

  6. Add some clarity to the config options

    @turt2live
    turt2live committed May 3, 2019
    Configuration menu
    Copy the full SHA
    ab6ba0e View commit details
    Browse the repository at this point in the history

  7. Add a couple notes

    @turt2live
    turt2live committed May 3, 2019
    Configuration menu
    Copy the full SHA
    45caa8b View commit details
    Browse the repository at this point in the history

  8. Handle cases of no default server

    @turt2live
    turt2live committed May 3, 2019
    Configuration menu
    Copy the full SHA
    bf97fd6 View commit details
    Browse the repository at this point in the history

  9. Fix tests to use new server config options

    @turt2live
    turt2live committed May 3, 2019
    Configuration menu
    Copy the full SHA
    a5092dc View commit details
    Browse the repository at this point in the history

  10. Fix unit tests for new login 

    Supply a server config to the component and adjust the wait logic to be less of a race. The Login component will noop onPasswordLogin if it is "busy", and it is busy when it requests the login flows.
    @turt2live
    turt2live committed May 3, 2019
    Configuration menu
    Copy the full SHA
    fc5c93a View commit details
    Browse the repository at this point in the history