Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send media, file, take photo, take video #52

Closed
4 of 5 tasks
bmarty opened this issue Feb 26, 2019 · 13 comments
Closed
4 of 5 tasks

Send media, file, take photo, take video #52

bmarty opened this issue Feb 26, 2019 · 13 comments
Assignees
Milestone

Comments

@bmarty
Copy link
Member

bmarty commented Feb 26, 2019

Using a media preview screen before sending media to the room

  • Handle sending media - SDK side (audio,image, video, file)
  • File picker
  • Take picture with camera
  • Take video with camera
  • Ask user for quality level before sending images
@bmarty bmarty added this to the Phase 1 milestone Mar 11, 2019
@bmarty bmarty changed the title Send media Send media, file, take photo, take video Mar 11, 2019
@ganfra
Copy link
Member

ganfra commented Apr 11, 2019

The SDK stuff has been done. At the moment UI offers only picking media with help of a library.
It should be replaced by a homemade implementation.

@vurpo
Copy link

vurpo commented Jun 11, 2019

I wish Riot X rather used the standard Android file picker than the homemade one it uses now (like the current Riot.im app does). That would automatically allow for picking files to send from custom folders, external media, or from other apps (such as Nextcloud or Google Photos or whatever apps you have installed).

@vurpo
Copy link

vurpo commented Jun 11, 2019

To demonstrate, here I can choose files to upload from Nextcloud, from Google Photos, or from external SD cards or USB drives if I had any of those plugged in.

Screenshot_20190611-123312_Files

@bmarty
Copy link
Member Author

bmarty commented Jun 20, 2019

@vurpo yes we will use the classical android file picker intent

@jtagcat
Copy link

jtagcat commented Jul 15, 2019

@vurpo current Riot.im also allows the android one, though I for example, like that you can pick images in the app. The android picker could be under 'other file' picker (+ icon), since it can allow picking any file.

@bmarty bmarty modified the milestones: Phase 1, sprint2 Jul 19, 2019
@progserega
Copy link

It will be nice if when send video - it will be recompress (many video have big size):
#442

@ptman
Copy link

ptman commented Jul 30, 2019

@progserega compress on the phone before uploading? or on the server before downloading?

@progserega
Copy link

On the phone before download - as in whatsapp.
Because if user will record HD video in 1040p - then 5 minutes will be big size. And it is will can not upload to server.

@jtagcat
Copy link

jtagcat commented Aug 1, 2019

Note: Failure of uploading files (especially uploading files too big) results RiotX roadblocking (no messages in, no messages out and can't cancel sending the blocking video, though, notifications are received). Current resolution to the roadblock is to clear data of the app from android.

@bmarty bmarty removed the phase1 label Aug 8, 2019
@bmarty bmarty modified the milestones: sprint2, sprint3 Aug 8, 2019
@matrixes
Copy link

I just had what I think is a similar issue as what @jtagcat mentions; I tried to upload a file on a slow network, and the upload stalled because of timeout. No matter how many times I retried, RiotX wouldn't be able to upload it.
So, in an attempt to see if I could circumvent the timeout, I crimped the file to 1/4 of the original and uploaded that instead.
However, I realised too late that I can't cancel any of the previous timed out upload attempts, so now I'm stuck with multiple upload items that never finishes and can't be cancelled.
Only clearing data and logging back in makes the app behave properly again.
Cancelling pending actions would certainly improve the user experience here.

@progserega
Copy link

RiotX is not usable for send images in original size (without alternatives scale size). If network is lower then wifi or LTE - sending is a problem, because size of images from modern cameras is big.

@bmarty bmarty modified the milestones: sprint3, Stabilization1 Sep 3, 2019
@bmarty bmarty modified the milestones: Stabilization1, sprint4 Oct 9, 2019
@fbruetting
Copy link

If you shrink images, please provide a choice for three different quality levels and uncompressed!

@bmarty
Copy link
Member Author

bmarty commented Oct 23, 2019

Ok, done in #619
Image quality will be handled (maybe?) in #631

@bmarty bmarty closed this as completed Oct 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants