Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

joining a room over federation seems to get stuck #1314

Closed
matrixbot opened this issue Mar 29, 2016 · 4 comments
Closed

joining a room over federation seems to get stuck #1314

matrixbot opened this issue Mar 29, 2016 · 4 comments
Assignees
Labels
P1 S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect

Comments

@matrixbot
Copy link

Created by @ richvdh:matrix.org.

I tried to join #vector via sw1v.org, but I just got a spinner of doom

STR:

  • open directory
  • enter #alias:domain
  • click 'join' in preview bar
  • observe spinner of doom
@ara4n ara4n added T-Defect P1 S-Major Severely degrades major functionality or product features, with no satisfactory workaround labels Apr 4, 2016
@ara4n ara4n added this to the v1 - Private Preview milestone Apr 4, 2016
@richvdh
Copy link
Member

richvdh commented Apr 8, 2016

The problem here is that RoomView is created with props.roomId set to the room alias, rather than the room ID, which means that later events in the room are being ignored.

We should probably:

  • get rid of the redundant props.roomId vs props.roomAlias - we only need one of them.
  • store the roomId in RoomView instead (it doesn't need to go into state)
  • store the roomId when we get the response from joinRoom.

@ara4n
Copy link
Member

ara4n commented Apr 13, 2016

seems very similar/related to #1047?

@richvdh
Copy link
Member

richvdh commented Apr 13, 2016

Yup looks like a dupe, will close the other

@richvdh
Copy link
Member

richvdh commented Apr 13, 2016

Hopefully this will be fixed by matrix-org/matrix-react-sdk#270

@richvdh richvdh closed this as completed Apr 13, 2016
richvdh added a commit that referenced this issue Apr 13, 2016
Including a regression test for
#1314
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect
Projects
None yet
Development

No branches or pull requests

3 participants