Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Something needs to set a sensible default for guest displaynames, e.g. 'Guest' (probably the server?) #759

Closed
matrixbot opened this issue Jan 25, 2016 · 5 comments
Closed

Something needs to set a sensible default for guest displaynames, e.g. 'Guest' (probably the server?) #759

matrixbot opened this issue Jan 25, 2016 · 5 comments
Labels
P1 S-Major Severely degrades major functionality or product features, with no satisfactory workaround X-Release-Blocker
Milestone
v0 - Friendly Beta

Comments

@matrixbot
Copy link

Created by @ matthew:matrix.org.
@AmandineLP AmandineLP added P1 S-Major Severely degrades major functionality or product features, with no satisfactory workaround labels Jan 25, 2016
@AmandineLP AmandineLP added this to the v0 - Friendly Beta milestone Jan 25, 2016
@AmandineLP AmandineLP mentioned this issue Jan 27, 2016
Closed
@AmandineLP
Copy link
Contributor

If we force guests to pick a display name (#758; #778), can we use this name to create a sensible username?
That would allow them to have a meaningful username when they upgrade and register (see #781).

@AmandineLP AmandineLP mentioned this issue Jan 29, 2016
Closed
@dbkr
Copy link
Member

dbkr commented Feb 1, 2016

The problem with deriving a username from a chosen display name is that we're then essentially allowing users to reserve a username without going through the registration process, which may be undesirable?

@AmandineLP
Copy link
Contributor

Agreed behavior: calculate monotonically increasing guest IDs like @1234:matrix.org

@dbkr
Copy link
Member

dbkr commented Feb 1, 2016

Hold on - this bug is talking about display names rather than usernames. I thought the agreed flow was that the display name would be unset until they tried to join a room, then we prompt the user to set it, with a default of, "Guest [their numeric user ID]"?

@dbkr
Copy link
Member

dbkr commented Feb 4, 2016

Fixed along with #758

@dbkr dbkr closed this as completed Feb 4, 2016
dbkr added a commit to matrix-org/matrix-react-sdk that referenced this issue Mar 4, 2016
@dbkr
Re-enable upgrade registration.
4da0e2f 
Revert element-hq/element-web#818 now that element-hq/element-web#759 is fixed.
dbkr added a commit that referenced this issue Mar 4, 2016
@dbkr
Re-enable upgrade registration.
d732927 
Revert #818 now that #759 is fixed.
This was referenced Mar 4, 2016
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
P1 S-Major Severely degrades major functionality or product features, with no satisfactory workaround X-Release-Blocker
Projects
None yet
Milestone
v0 - Friendly Beta
Development

No branches or pull requests
3 participants
@dbkr @AmandineLP @matrixbot