Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate annotations for headless vector service #267

Open
trexx opened this issue Nov 8, 2022 · 3 comments
Open

Separate annotations for headless vector service #267

trexx opened this issue Nov 8, 2022 · 3 comments

Comments

@trexx
Copy link

trexx commented Nov 8, 2022

Hi,

We use External DNS annotations to publish DNS records for the vector service. It seems the headless service is also getting the same annotation causing extraneous and useless DNS records to be published.

Would a PR be welcome to separate the two?

@spencergilbert
Copy link
Contributor

👋

Hey, I actually looked at this recently but couldn't land on a UX I liked while working on #257. If I recall correctly, I wasn't able to find a nice way to avoid users from having to duplicate labels/annotations if they did want the same across both services.

@datsabk
Copy link

datsabk commented Jan 17, 2023

@spencergilbert - Why not just have a single service and allow definition of type for it ?

OR

Allow users to have array of services ?

@spencergilbert
Copy link
Contributor

Hey @datsabk - do you have an example of what that would look like?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants