feat(vector): Support enable for both the normal and headless service #257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spencergilbert
force-pushed
the
spencer/separate-headless-service-conf
branch
2 times, most recently
from
6ddb1d1
to
8aba8d0
Compare
…service The headless service can be disabled and configured separately, but the default behavior will be to reuse the config from the service. Signed-off-by: Spencer Gilbert <spencer.gilbert@datadoghq.com>
spencergilbert
force-pushed
the
spencer/separate-headless-service-conf
branch
from
8aba8d0
to
7e8355f
Compare
Signed-off-by: Spencer Gilbert <spencer.gilbert@datadoghq.com>
neuronull
approved these changes
Oct 20, 2022
spencergilbert
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously both a standard and headless service were enabled and configured by the same values. This PR allows for the headless service to be disabled separately.
The headless service is particularly useful for the in-chart HAProxy loadbalancer, but for production deploys users should leverage the standard service with a
LoadBalancertype (and relevant configurations, generally annotation driven, their cloud provider requires).Closes #253
Signed-off-by: Spencer Gilbert spencer.gilbert@datadoghq.com