Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configuring librdkafka_options in the source or sink is impossible with a customConfig #349

Closed
ogarcia opened this issue Dec 1, 2023 · 3 comments
Labels
bug Something isn't working

Comments

@ogarcia
Copy link

ogarcia commented Dec 1, 2023

I put this here more than anything so that nobody has to waste hours of their life for this, I think the fault is really in Helm and not in the template (I have opened an issue for this).

For example, having this configuration:

role: Agent
service:
    enabled: false
serviceHeadless:
    enabled: false
customConfig:
    data_dir: /vector-data-dir
    api:
        enabled: true
        address: 127.0.0.1:8686
        playground: false
    sources:
        kubernetes_logs:
            type: kubernetes_logs
    sinks:
        kafka:
            type: kafka
            inputs:
                - kubernetes_logs
            bootstrap_servers: the.kafka.server:9093
            topic: aprettytopic
            encoding:
                codec: json
            sasl:
                enabled: true
                mechanism: PLAIN
                username: user
                password: pass
            librdkafka_options:
                "security.protocol": sasl_ssl

When applied, Helm removes the quotes from "security.protocol" and leaves the string as security.protocol, which is not interpreted correctly by Vector.

I don't think there is any way to solve this problem. Not at least without it being fixed by Helm, but if anyone has any ideas, they are welcome.

@jszwedko
Copy link
Member

jszwedko commented Dec 7, 2023

One workaround Vector could do here is to flatten anything under librdkafka_options. This does seem like a potential Helm bug though, I'll respond over on that issue too.

@jszwedko
Copy link
Member

jszwedko commented Dec 7, 2023

As a workaround, you might also provide the config as JSON as suggested in the Helm issue:

librdkafka_options:
                { "security.protocol": sasl_ssl }

@jszwedko jszwedko added the bug Something isn't working label Dec 7, 2023
@ogarcia
Copy link
Author

ogarcia commented Dec 11, 2023

As described in this comment, in the end this issue is not a bug.

@ogarcia ogarcia closed this as not planned Won't fix, can't repro, duplicate, stale Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants