Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

statsd source - support DD #1974

Closed
afoninsky opened this issue Mar 3, 2020 · 3 comments
Closed

statsd source - support DD #1974

afoninsky opened this issue Mar 3, 2020 · 3 comments
Labels
domain: data model Anything related to Vector's internal data model domain: metrics Anything related to Vector's metrics events source: statsd Anything `statsd` source related type: enhancement A value-adding code change that enhances its existing functionality.

Comments

@afoninsky
Copy link

I have an error trying to switch from DataDog agent to Vector.

vector-6f95d89b5c-m48c9 vector Mar 03 14:46:50.423 ERROR source{name=statsd type=statsd}: vector::sources::statsd: Statsd parse error: UnknownMetricType("d")

Looks like services support it. Example: https://github.com/prometheus/statsd_exporter

Note that timers will be accepted with the ms, h, and d statsd types. The first two are timers and histograms and the d type is for DataDog's "distribution" type. The distribution type is treated identically to timers and histograms.

It's a good idea to support DD specific types so Vector can replace DD agent. What do you think?

@binarylogic binarylogic added event type: metric source: statsd Anything `statsd` source related type: enhancement A value-adding code change that enhances its existing functionality. labels Mar 3, 2020
@binarylogic
Copy link
Contributor

Very much agree! We'll build out support for this. We're planning to focus heavily on metrics this quarter.

@afoninsky
Copy link
Author

#2603 - same issue here

@binarylogic binarylogic added domain: data model Anything related to Vector's internal data model domain: metrics Anything related to Vector's metrics events and removed event type: metric labels Aug 6, 2020
@binarylogic
Copy link
Contributor

@afoninsky I'm closing this in favor of #2603 and #2913. Vector should no longer error on this type but we still have work to do sending distributions to Datadog. We are working with Datadog to get clarity on the issues described in #3130.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain: data model Anything related to Vector's internal data model domain: metrics Anything related to Vector's metrics events source: statsd Anything `statsd` source related type: enhancement A value-adding code change that enhances its existing functionality.
Projects
None yet
Development

No branches or pull requests

2 participants