Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider cheaper representations of metric label data #2160

Closed
lukesteensen opened this issue Mar 26, 2020 · 1 comment
Closed

Consider cheaper representations of metric label data #2160

lukesteensen opened this issue Mar 26, 2020 · 1 comment
Assignees
Labels
domain: data model Anything related to Vector's internal data model domain: metrics Anything related to Vector's metrics events domain: performance Anything related to Vector's performance needs: approval Needs review & approval before work can begin. type: enhancement A value-adding code change that enhances its existing functionality.

Comments

@lukesteensen
Copy link
Member

We currently represent metric labels as full Strings. This is a simple and ergonomic choice but has a cost in memory use and copying.

Alternative representations like Atom and Cow-like structures could reduce this cost. With proper benchmarking, we can evaluate performance differences and weight them with concerns like ergonomics to decide if switching is worthwhile.

Originally brought up by @LucioFranco here.

@lukesteensen lukesteensen added event type: metric needs: approval Needs review & approval before work can begin. labels Mar 26, 2020
@binarylogic binarylogic added type: enhancement A value-adding code change that enhances its existing functionality. domain: performance Anything related to Vector's performance domain: data model Anything related to Vector's internal data model domain: metrics Anything related to Vector's metrics events and removed type: performance labels Aug 6, 2020
@jszwedko
Copy link
Member

Closing since we'll let profiling motivate future performance changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain: data model Anything related to Vector's internal data model domain: metrics Anything related to Vector's metrics events domain: performance Anything related to Vector's performance needs: approval Needs review & approval before work can begin. type: enhancement A value-adding code change that enhances its existing functionality.
Projects
None yet
Development

No branches or pull requests

4 participants