Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add IPv6-related options to the http sink #2508

Open
ghost opened this issue Apr 30, 2020 · 7 comments
Open

Add IPv6-related options to the http sink #2508

ghost opened this issue Apr 30, 2020 · 7 comments
Labels
domain: networking Anything related to Vector's networking domain: sinks Anything related to the Vector's sinks have: should We should have this feature, but is not required. It is medium priority. needs: approval Needs review & approval before work can begin. sink: http Anything `http` sink related type: enhancement A value-adding code change that enhances its existing functionality.

Comments

@ghost
Copy link

ghost commented Apr 30, 2020

I propose to add new options to the configuration of the http sink which would allow the user to configure behavior of the sink when the target host is available on both IPv4 and IPv6 addresses.

For example, there might be two new options:

@ghost ghost added type: enhancement A value-adding code change that enhances its existing functionality. domain: sinks Anything related to the Vector's sinks labels Apr 30, 2020
@binarylogic binarylogic added sink: http Anything `http` sink related needs: approval Needs review & approval before work can begin. labels Apr 30, 2020
@LucioFranco
Copy link
Contributor

This may be relevant hyperium/hyper#1937

@binarylogic binarylogic added have: should We should have this feature, but is not required. It is medium priority. domain: networking Anything related to Vector's networking labels Aug 7, 2020
@thameezb
Copy link

thameezb commented Aug 9, 2023

Any update on this?

@jszwedko
Copy link
Member

jszwedko commented Aug 9, 2023

Any update on this?

Nothing yet, but could describe the use-case you have for this? E.g. do you just need the happy_eyeballs_timeout_ms setting? Something else?

@thameezb
Copy link

thameezb commented Aug 10, 2023

Any update on this?

Nothing yet, but could describe the use-case you have for this? E.g. do you just need the happy_eyeballs_timeout_ms setting? Something else?

Rereading the issue I might be at the incorrect location :)

We run an IPv6 EKS cluster, and would like to use vector in HTTP server mode (https://vector.dev/docs/reference/configuration/sources/http_server/). However seemingly it cannot listen on :: (we have tried :::PORT and [::]:PORT and both throw errors.

I had assumed this was enabling IPv6 support for the HTTP server source (but now realise its the sink)

@jszwedko
Copy link
Member

Any update on this?

Nothing yet, but could describe the use-case you have for this? E.g. do you just need the happy_eyeballs_timeout_ms setting? Something else?

Rereading the issue I might be at the incorrect location :)

We run an IPv6 EKS cluster, and would like to use vector in HTTP server mode (https://vector.dev/docs/reference/configuration/sources/http_server/). However seemingly it cannot listen on :: (we have tried :::PORT and [::]:PORT and both throw errors.

I had assumed this was enabling IPv6 support for the HTTP server source (but now realise its the sink)

Ah, I see. What are the errors you are seeing? I tried it just now and was able to bind to [::]:8080 successfully. This seems to be unrelated to this issue so you could open a separate one or a discussion.

@thameezb
Copy link

Any update on this?

Nothing yet, but could describe the use-case you have for this? E.g. do you just need the happy_eyeballs_timeout_ms setting? Something else?

Rereading the issue I might be at the incorrect location :)
We run an IPv6 EKS cluster, and would like to use vector in HTTP server mode (https://vector.dev/docs/reference/configuration/sources/http_server/). However seemingly it cannot listen on :: (we have tried :::PORT and [::]:PORT and both throw errors.
I had assumed this was enabling IPv6 support for the HTTP server source (but now realise its the sink)

Ah, I see. What are the errors you are seeing? I tried it just now and was able to bind to [::]:8080 successfully. This seems to be unrelated to this issue so you could open a separate one or a discussion.

Thank you for the swift responses. Indeed it does work (and quite seamlessly I might add)

I decided to interact with the issue directly (vs going via the security team which was having the issue) and after much digging the issue is on our side, through the various terraform templating, matched with helm templating, until it hits the k8s configmap (missing quotes which meant the [::]:PORT was not being read correctly

@jszwedko
Copy link
Member

I decided to interact with the issue directly (vs going via the security team which was having the issue) and after much digging the issue is on our side, through the various terraform templating, matched with helm templating, until it hits the k8s configmap (missing quotes which meant the [::]:PORT was not being read correctly

Aha! Glad you sorted it out!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain: networking Anything related to Vector's networking domain: sinks Anything related to the Vector's sinks have: should We should have this feature, but is not required. It is medium priority. needs: approval Needs review & approval before work can begin. sink: http Anything `http` sink related type: enhancement A value-adding code change that enhances its existing functionality.
Projects
None yet
Development

No branches or pull requests

4 participants