Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define events for the vector source #3209

Closed
7 tasks done
binarylogic opened this issue Jul 25, 2020 · 2 comments · Fixed by #3316
Closed
7 tasks done

Define events for the vector source #3209

binarylogic opened this issue Jul 25, 2020 · 2 comments · Fixed by #3316
Assignees
Labels
domain: observability Anything related to monitoring/observing Vector source: vector Anything `vector` source related type: enhancement A value-adding code change that enhances its existing functionality.

Comments

@binarylogic
Copy link
Contributor

binarylogic commented Jul 25, 2020

As part of finishing https://github.com/timberio/vector-product/issues/14, we need to define internal events for the vector source.

Special Note

To my knowledge, this source wraps the socket source. I'm curious how we should approach defining events in this case, since we do not emit duplicate events (ex: *EventReceived events).

Defining events

Requirements

  • Add a VectorEventReceived event.
    • Derive a events_processed metric via the emit_metrics method. (example)
    • If possible, derive a bytes_processed metric via the emit_metrics method. (example)
  • Audit and add events for all possible errors. (example)
  • Audit and add events for all component-specific behavior. (example)
  • Ensure that logs in the hot path are rate limited via the rate_limit_secs parameter. (example).
  • Ensure that all log messages start with a lowercase letter and end with a .. (example)
@binarylogic binarylogic added type: enhancement A value-adding code change that enhances its existing functionality. domain: observability Anything related to monitoring/observing Vector source: vector Anything `vector` source related labels Jul 25, 2020
@ktff
Copy link
Contributor

ktff commented Aug 2, 2020

Was done in #1953

@ktff
Copy link
Contributor

ktff commented Aug 2, 2020

this source wraps the socket source. I'm curious how we should approach defining events in this case

@binarylogic it was wrapping socket source, now the shared code is separated. For vector source, that is tcp code which only emits a generic TcpConnectionError that covers all errors that get propagated to it, and it's own. While vector source emits it's own VectorEventReceived.

@ktff ktff closed this as completed in #3316 Aug 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain: observability Anything related to monitoring/observing Vector source: vector Anything `vector` source related type: enhancement A value-adding code change that enhances its existing functionality.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants