Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make blackhole sink's print_amount field optional #3886

Closed
JeanMertz opened this issue Sep 15, 2020 · 2 comments · Fixed by #4883
Closed

make blackhole sink's print_amount field optional #3886

JeanMertz opened this issue Sep 15, 2020 · 2 comments · Fixed by #4883
Assignees
Labels
domain: config Anything related to configuring Vector have: nice This feature is nice to have. It is low priority. sink: blackhole Anything `blackhole` sink related type: feature A value-adding code addition that introduce new functionality.

Comments

@JeanMertz
Copy link
Contributor

JeanMertz commented Sep 15, 2020

While testing out a local Vector configuration in #230 (comment), I ran into #3885.

That got me thinking, I wonder if we should consider making print_amount an optional field. Its purpose is orthogonal to what the actual sink is supposed to do, and given that this sink seems like a good fit for quickly testing something, the less configuration it requires, the better.

@JeanMertz JeanMertz added domain: config Anything related to configuring Vector sink: blackhole Anything `blackhole` sink related type: feature A value-adding code addition that introduce new functionality. labels Sep 15, 2020
@binarylogic binarylogic added the have: nice This feature is nice to have. It is low priority. label Sep 15, 2020
@binarylogic binarylogic added this to the 2020-09-14 - The Grid milestone Sep 15, 2020
@lukesteensen
Copy link
Member

I would really like to get rid of this option entirely. I don't find it useful at all. I think we could have the sink periodically emit how many messages it has received (though even that could be done better with a reduce transform?) or some other form of feedback, but I'm not sure what would be most useful.

@JeanMertz
Copy link
Contributor Author

I actually agree with you @lukesteensen. One reason I've seen people wanting this is so that their tooling doesn't consider Vector to be stuck if it no longer produces output.

I would say for that we have a much better solution now, the internal_metrics source.

Given that, I think we should just purge this field, and the output this sink generates, entirely.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain: config Anything related to configuring Vector have: nice This feature is nice to have. It is low priority. sink: blackhole Anything `blackhole` sink related type: feature A value-adding code addition that introduce new functionality.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants