Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

InFlightLimit::None cannot be deserialized #4190

Closed
juchiast opened this issue Sep 29, 2020 · 1 comment · Fixed by #4192
Closed

InFlightLimit::None cannot be deserialized #4190

juchiast opened this issue Sep 29, 2020 · 1 comment · Fixed by #4192
Assignees
Labels
domain: config Anything related to configuring Vector type: bug A code related bug.

Comments

@juchiast
Copy link
Contributor

This breaks vector generate for sinks that have TowerRequestConfig in there config struct. For example, sink aws_s3:

Generated config:

data_dir = "/var/lib/vector/"

[sinks.sink0]
healthcheck = true
inputs = ["TODO"]
bucket = ""
compression = "none"
type = "aws_s3"

[sinks.sink0.batch]

[sinks.sink0.request]
in_flight_limit = "None"

[sinks.sink0.request.auto_concurrency]
decrease_ratio = 0.9
ewma_alpha = 0.5
rtt_threshold_ratio = 0.05

[sinks.sink0.buffer]
type = "memory"
max_events = 500
when_full = "block"

Error:

unknown variant `None`, expected `auto` for key `sinks.sink0`
@juchiast juchiast added type: bug A code related bug. domain: config Anything related to configuring Vector domain: parsing Anything related to parsing within Vector labels Sep 29, 2020
@binarylogic binarylogic added this to the 2020-09-28 - Derezzed milestone Sep 29, 2020
@juchiast juchiast assigned juchiast and unassigned bruceg Sep 29, 2020
@juchiast
Copy link
Contributor Author

hmm I sent a PR..

@juchiast juchiast removed the domain: parsing Anything related to parsing within Vector label Sep 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain: config Anything related to configuring Vector type: bug A code related bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants