Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle Windows line endings #4857

Open
jszwedko opened this issue Nov 3, 2020 · 0 comments
Open

Handle Windows line endings #4857

jszwedko opened this issue Nov 3, 2020 · 0 comments
Labels
platform: windows Anything `windows` platform related type: enhancement A value-adding code change that enhances its existing functionality.

Comments

@jszwedko
Copy link
Member

jszwedko commented Nov 3, 2020

Spun off from #4779 (comment)

Currently we hardcode line endings to \n for at least the following sources: file, udp, tcp, statsd, http, aws_s3.

For portability reasons, we should probably accept \r\n as well.
@jszwedko jszwedko added the type: enhancement A value-adding code change that enhances its existing functionality. label Nov 3, 2020
@jszwedko jszwedko mentioned this issue Nov 3, 2020
Merged
@jszwedko jszwedko added the platform: windows Anything `windows` platform related label Aug 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
platform: windows Anything `windows` platform related type: enhancement A value-adding code change that enhances its existing functionality.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jszwedko