Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add reload subcommand #541

Open
binarylogic opened this issue Jun 24, 2019 · 3 comments
Open

Add reload subcommand #541

binarylogic opened this issue Jun 24, 2019 · 3 comments
Labels
domain: cli Anything related to Vector's CLI domain: reload Anything related to reloading Vector (updating configuration) have: should We should have this feature, but is not required. It is medium priority. type: enhancement A value-adding code change that enhances its existing functionality.

Comments

@binarylogic
Copy link
Contributor

We need a snychronous sub-command that reloads configuration. From the systemd docs:

Note however that reloading a daemon by sending a signal (as with the example line above) is usually not a good choice, because this is an asynchronous operation and hence not suitable to order reloads of multiple services against each other. It is strongly recommended to set ExecReload= to a command that not only triggers a configuration reload of the daemon, but also synchronously waits for it to complete.

I assume we can just execute the same path we do when we receive a SIGHUP, but we must wait to respond only after the change is complete.

@binarylogic binarylogic added type: enhancement A value-adding code change that enhances its existing functionality. domain: cli Anything related to Vector's CLI labels Jun 24, 2019
@lukesteensen
Copy link
Member

This might be a good time to introduce the beginning of an admin HTTP API. The subcommand could then just hit a synchronous /reload endpoint.

@CameronNemo
Copy link

The asynchronicity is only a problem if you need to do ordering based on the reload, right? What use case did you have in mind?

@binarylogic binarylogic added domain: reload Anything related to reloading Vector (updating configuration) have: should We should have this feature, but is not required. It is medium priority. labels Aug 7, 2020
@sinacek
Copy link

sinacek commented Mar 17, 2023

Hi, I have use case for similar behaviour vectordotdev/helm-charts#281 (comment) . I'm looking for http endpoint which will reload the configuration in same way, how it does Prometheus.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain: cli Anything related to Vector's CLI domain: reload Anything related to reloading Vector (updating configuration) have: should We should have this feature, but is not required. It is medium priority. type: enhancement A value-adding code change that enhances its existing functionality.
Projects
None yet
Development

No branches or pull requests

5 participants