Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update librdkafka #5491

Closed
lukesteensen opened this issue Dec 11, 2020 · 4 comments
Closed

Update librdkafka #5491

lukesteensen opened this issue Dec 11, 2020 · 4 comments
Assignees
Labels
sink: kafka Anything `kafka` sink related source: kafka Anything `kafka` source related type: task Generic non-code related tasks

Comments

@lukesteensen
Copy link
Member

There was a report in discord of a strange Kafka error related to API protocol versions:

DEBUG librdkafka: librdkafka: PROTOERR [thrd:foo.cloudapp.net:]: my-kafka-broker:9092/1003: Protocol parse failure for ApiVersion v3 at 3/6 (rd_kafka_handle_ApiVersion:1915) (incorrect broker.version.fallback?)    
Dec 11 08:37:17.946 DEBUG librdkafka: librdkafka: PROTOERR [thrd:my-kafka-broker:]: my-kafka-broker:9092/1003: ApiArrayCnt -1 out of range

Our current version of rdkafka should work perfectly with their reported version of Kafka (2.1.1), but it's possible they're hitting a bug in the underlying library. I noticed that the latest version of librdkafka is 1.5.3 and our rdkafka crate is only on 1.4.2, with one entry in the changelog mentioning broker.version.fallback. It would be good to update to the lasest to ensure this isn't a bug that's been fixed upstream.

This will likely involve contributing the update to the rdkafka crate we use.

@lukesteensen lukesteensen added sink: kafka Anything `kafka` sink related type: task Generic non-code related tasks source: kafka Anything `kafka` source related labels Dec 11, 2020
@binarylogic binarylogic added this to the 2020-12-21 Kryptek Yeti milestone Dec 11, 2020
@jamtur01 jamtur01 removed this from the 2020-12-21 Kryptek Yeti milestone Dec 21, 2020
@jamtur01 jamtur01 self-assigned this Dec 21, 2020
@jamtur01 jamtur01 added this to the 2020-12-21 Kryptek Yeti milestone Dec 21, 2020
@jamtur01 jamtur01 added the meta: blocked Anything that is blocked to the point where it cannot be worked on. label Dec 30, 2020
@jamtur01
Copy link
Contributor

We're stuck on an rdkafka release here: fede1024/rust-rdkafka#299

@binarylogic
Copy link
Contributor

It looks like a new version has been released: fede1024/rust-rdkafka#299 (comment)

@binarylogic binarylogic removed the meta: blocked Anything that is blocked to the point where it cannot be worked on. label Jan 30, 2021
@eeyun
Copy link
Contributor

eeyun commented Feb 8, 2021

Worth mentioning that rdkafka 0.25.0 requires a tokio runtime of 1.x now. The latest release also includes librdkafka 1.6.0 so I think there's no need to contribute upstream, but it does put us in a predicament, unless I'm misunderstanding. We can't upgrade to rdkafk 0.25.0 a until we upgrade to tokio 1.x unless we write a compat layer. Since the work to make that migration is underway, I doubt it makes sense to do the compat here? Open to other's opinions of course.

@binarylogic binarylogic assigned pablosichert and unassigned eeyun Feb 22, 2021
@binarylogic binarylogic modified the milestones: 2021-02-01 D-Fuel, 2021-02-22 - Scottish Deerhound Feb 22, 2021
@pablosichert
Copy link
Contributor

The bump to rdkafka 0.26.0 has landed with #5872.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sink: kafka Anything `kafka` sink related source: kafka Anything `kafka` source related type: task Generic non-code related tasks
Projects
None yet
Development

No branches or pull requests

5 participants