Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure all sink batches are counted by serialized bytes #574

Closed
LucioFranco opened this issue Jul 3, 2019 · 1 comment
Closed

Ensure all sink batches are counted by serialized bytes #574

LucioFranco opened this issue Jul 3, 2019 · 1 comment
Labels
sink: aws_cloudwatch_logs Anything `aws_cloudwatch_logs` sink related type: bug A code related bug. type: task Generic non-code related tasks type: tech debt A code change that does not add user value.

Comments

@LucioFranco
Copy link
Contributor

Currently, we expect all sinks to represent batch sizes in terms of bytes. Right now the only sink that doesn't support this is the cloudwatch sink. This should be supported to be consistent across all sinks and allow us to actually follow cloudwatch's payload limits which are stated in terms of bytes.
@LucioFranco LucioFranco added type: bug A code related bug. sink: aws_cloudwatch_logs Anything `aws_cloudwatch_logs` sink related type: tech debt A code change that does not add user value. type: task Generic non-code related tasks labels Jul 3, 2019
@LucioFranco LucioFranco self-assigned this Jul 3, 2019
@LucioFranco LucioFranco mentioned this issue Jul 3, 2019
Merged
@LucioFranco
Copy link
Contributor Author

This has been solved by #1493

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
sink: aws_cloudwatch_logs Anything `aws_cloudwatch_logs` sink related type: bug A code related bug. type: task Generic non-code related tasks type: tech debt A code change that does not add user value.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@LucioFranco