Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kubernetes helm chart: add api configuration to the vector-aggregator #6227

Closed
dzirg44 opened this issue Jan 25, 2021 · 2 comments
Closed

Kubernetes helm chart: add api configuration to the vector-aggregator #6227

dzirg44 opened this issue Jan 25, 2021 · 2 comments
Labels
type: enhancement A value-adding code change that enhances its existing functionality.

Comments

@dzirg44
Copy link
Contributor

dzirg44 commented Jan 25, 2021

Current Vector Version

nightly-2021-01-20-debian docker image

Use-cases

for some reasons (like healthchecks or external services api requests) we can add a possibility to configure it.

Attempted Solutions

i created a simple fix
https://github.com/dzirg44/vector/blob/service-type/distribution/helm/vector-aggregator/templates/configmap.yaml
but I am not sure about implementation. Should we use vector-shared templates for it? Or just keep it simple as possible.
Or maybe create more general helper.
Also, should we create an additional service for it? Or just use internal service configuration.

@dzirg44 dzirg44 added the type: enhancement A value-adding code change that enhances its existing functionality. label Jan 25, 2021
@MOZGIII
Copy link
Contributor

MOZGIII commented Jan 25, 2021

Thanks for bringing this up!
This can be at libvector.vectorConfigHeader, and it does make sense to use vector-shared for this.
Would you be interested in submitting a PR for this?

Also, should we create an additional service for it? Or just use internal service configuration.

Currently, we don't see it used with a Service at all, but rather with kubectl port-forward. This makes way more sense, as you can explicitly connect directly to the instance you're looking for.

@dzirg44
Copy link
Contributor Author

dzirg44 commented Jan 25, 2021

okay, i will create a pull request !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement A value-adding code change that enhances its existing functionality.
Projects
None yet
Development

No branches or pull requests

2 participants