Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revive VRL function changes #6476

Closed
binarylogic opened this issue Feb 17, 2021 · 7 comments
Closed

Revive VRL function changes #6476

binarylogic opened this issue Feb 17, 2021 · 7 comments
Assignees
Labels
domain: vrl Anything related to the Vector Remap Language type: task Generic non-code related tasks

Comments

@binarylogic
Copy link
Contributor

It appears that #6353 dropped changes like #6052. We should audit and revive any changes like this that were dropped.

@binarylogic binarylogic added type: task Generic non-code related tasks domain: vrl Anything related to the Vector Remap Language labels Feb 17, 2021
@pablosichert
Copy link
Contributor

pablosichert commented Feb 18, 2021

Relevant PRs to be reviewed:


@pablosichert
Copy link
Contributor

I reviewed all of the PRs that have been merged between the opening of #6353 and now.

Really weird that #6052 has been dropped, since that landed on Jan 19, but the first commit on #6353 was on Feb 4.

@jszwedko
Copy link
Member

jszwedko commented Feb 18, 2021

It looks like the parent commit of the first commit on #6353 is 7e5f6ba which is actually January 19th so that branch was likely branched from a stale master.

@jszwedko
Copy link
Member

That might also mean you should expand the search window for possibly affected PRs?

@pablosichert
Copy link
Contributor

Very good point @jszwedko! Will do.

@pablosichert
Copy link
Contributor

Interesting, I remember exactly encountering and fixing it in passing: #6229.

Which affirms your point 😄

@pablosichert
Copy link
Contributor

pablosichert commented Feb 18, 2021

Let's hope I caught all. I didn't exhaustively review the huge pull requests, but did lots of probes for smaller changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain: vrl Anything related to the Vector Remap Language type: task Generic non-code related tasks
Projects
None yet
Development

No branches or pull requests

4 participants
@jszwedko @binarylogic @pablosichert and others