Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document "proper" way to add Datadog Tags #8353

Open
spencergilbert opened this issue Jul 16, 2021 · 3 comments
Open

Document "proper" way to add Datadog Tags #8353

spencergilbert opened this issue Jul 16, 2021 · 3 comments
Labels
domain: external docs Anything related to Vector's external, public documentation provider: datadog Anything `datadog` service provider related type: task Generic non-code related tasks

Comments

@spencergilbert
Copy link
Contributor

We had originally worked on a add_datadog_tag function for VRL, but (IIRC) moved to leverage our existing *_key_value functions that already offered control over delimiters.

If this is our blessed way forward we should document (or add a guide) for how we suggest managing events
Vector sends to Datadog.

Refs:
https://docs.datadoghq.com/agent/vector_aggregation/#overview
https://vector.dev/docs/reference/vrl/functions/#encode_key_value
#7751

@spencergilbert spencergilbert added type: task Generic non-code related tasks domain: external docs Anything related to Vector's external, public documentation labels Jul 16, 2021
@atibdialpad
Copy link

++ Observation
I am using Datadog Metrics and Datadog event sinks and I observed that 'tags' behave differently in both.
Datadog Metric Sink : 'tags' are an object/map {"key":value}
Datadog Event Sink: 'tags' are an array of String ["key:value"]

I find the Datadog Event Sink's representation more useful since Datadog internally also treats tags an an array of string. + it allows to multiple keys with different values like ["ip:1.2.3.4", "ip:1.2.3.5"], something which is not possible when tags are an object/dictionary/map.

@jszwedko
Copy link
Member

jszwedko commented Aug 6, 2021

A user noted that DD_TAGS, for the Datadog agent, also allows for space separated tags. They attempted to use space separated tags in Vector but found this didn't work as the Datadog API expects comma separated. We could consider automatically translating.

@spencergilbert
Copy link
Contributor Author

++ Observation
I am using Datadog Metrics and Datadog event sinks and I observed that 'tags' behave differently in both.
Datadog Metric Sink : 'tags' are an object/map {"key":value}
Datadog Event Sink: 'tags' are an array of String ["key:value"]

I find the Datadog Event Sink's representation more useful since Datadog internally also treats tags an an array of string. + it allows to multiple keys with different values like ["ip:1.2.3.4", "ip:1.2.3.5"], something which is not possible when tags are an object/dictionary/map.

🤔 it would be nice to standardize on that... I'm not sure if there was any reasoning behind why it was done that way.

@jszwedko jszwedko added the provider: datadog Anything `datadog` service provider related label Dec 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain: external docs Anything related to Vector's external, public documentation provider: datadog Anything `datadog` service provider related type: task Generic non-code related tasks
Projects
None yet
Development

No branches or pull requests

3 participants