Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New timescale sink #939

Open
binarylogic opened this issue Sep 26, 2019 · 7 comments
Open

New timescale sink #939

binarylogic opened this issue Sep 26, 2019 · 7 comments
Labels
domain: metrics Anything related to Vector's metrics events domain: sinks Anything related to the Vector's sinks needs: approval Needs review & approval before work can begin. needs: requirements Needs a a list of requirements before work can be begin sink: new A request for a new sink type: feature A value-adding code addition that introduce new functionality.

Comments

@binarylogic
Copy link
Contributor

binarylogic commented Sep 26, 2019

I'd like to support Timescale as a sink, and after talking to them it appears we just need to support Postgres since Timescale is built on Postgres. I'm hesitant to call it a Postgres sink given that we'll probably want to make certain assumptions about how we're writing data. Before we begin work we should determine if this is the appropriate course of action.

Ref #935

@binarylogic binarylogic added type: new feature needs: approval Needs review & approval before work can begin. labels Sep 26, 2019
@binarylogic binarylogic added this to the Initial metrics support milestone Sep 26, 2019
@ghost
Copy link

ghost commented Sep 28, 2019

I’m not familiar with Timescale, but wonder would it make sense support unified SQL sinks, which would include Postgres, ClickHouse, and at least for the sake of easy tests, SQLite. The idea is to have same configuration structure for them and, ideally, support some kind of automatic table creation/migrations.

@jamessewell
Copy link
Contributor

As far as writing data there is no difference between Timescale and Postgres.

It would be up to the user to configure the destination tables (and hypertables in the Timscaledb case) before the sink was used.

@akulkarni
Copy link

A general unified SQL sink might be challenging given the language variants between the different databases.

But @jamessewell is correct, there should be no difference in writing data between Timescale and Postgres (but there may be other reasons for creating a Timescale specific sink).

@binarylogic binarylogic added needs: requirements Needs a a list of requirements before work can be begin and removed needs: approval Needs review & approval before work can begin. labels Jan 13, 2020
@jamessewell
Copy link
Contributor

I forgot to note our progress here: this can be achieved using PostgREST (a REST gateway for PostgreSQL) . Performance is very good.

@binarylogic binarylogic added type: feature A value-adding code addition that introduce new functionality. and removed type: new feature labels Jun 16, 2020
@binarylogic binarylogic removed this from the Initial Metrics Support milestone Aug 2, 2020
@binarylogic binarylogic added domain: metrics Anything related to Vector's metrics events domain: sinks Anything related to the Vector's sinks needs: approval Needs review & approval before work can begin. labels Aug 7, 2020
@123BLiN
Copy link

123BLiN commented May 20, 2021

@jamessewell Could you please elaborate on details of your implementation of this if possible?
Are you using http sink to drop events to PostgREST? And how do you create some tables in timescaledb before starting to push events?

@ypid-geberit
Copy link
Contributor

Note that there is a more generic issue #6556 which should probably be implemented first. As discussed above, it might even already solve this issue.

@jszwedko jszwedko added the sink: new A request for a new sink label Aug 1, 2022
@jszwedko jszwedko changed the title New timescale / postgres sink New postgres sink Dec 28, 2022
@jszwedko jszwedko changed the title New postgres sink New timescale sink Dec 28, 2022
@jszwedko
Copy link
Member

Repurposing this to be for timescale specifically. #15765 is tracking a generic postgres sink.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain: metrics Anything related to Vector's metrics events domain: sinks Anything related to the Vector's sinks needs: approval Needs review & approval before work can begin. needs: requirements Needs a a list of requirements before work can be begin sink: new A request for a new sink type: feature A value-adding code addition that introduce new functionality.
Projects
None yet
Development

No branches or pull requests

7 participants